From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753385AbbCaK4k (ORCPT ); Tue, 31 Mar 2015 06:56:40 -0400 Received: from ozlabs.org ([103.22.144.67]:34219 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbbCaK4j (ORCPT ); Tue, 31 Mar 2015 06:56:39 -0400 In-Reply-To: <1424715500-21725-1-git-send-email-sudeep.holla@arm.com> To: Sudeep Holla , linux-kernel@vger.kernel.org, Anshuman Khandual From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras , Sudeep Holla Subject: Re: [RFC/RFT, RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure Message-Id: <20150331105637.39B451400DE@ozlabs.org> Date: Tue, 31 Mar 2015 21:56:37 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-23-02 at 18:18:20 UTC, Sudeep Holla wrote: > This patch removes the redundant sysfs cacheinfo code by reusing > the newly introduced generic cacheinfo infrastructure through the > commit 246246cbde5e ("drivers: base: support cpu cache information > interface to userspace via sysfs") > > Signed-off-by: Sudeep Holla > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Anshuman Khandual > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/kernel/cacheinfo.c | 811 +++++----------------------------------- > arch/powerpc/kernel/cacheinfo.h | 8 - > arch/powerpc/kernel/sysfs.c | 12 +- > 3 files changed, 91 insertions(+), 740 deletions(-) > delete mode 100644 arch/powerpc/kernel/cacheinfo.h > > Hi, > > This patch is not tested. Last time Anshuman tested, he had seen issues. > The core driver has changed a lot after that. Since PPC depends a lot > on DT for cache information, there might be issues in the core later > which I could not identify with ARM/ARM64. It would be much appreciable > if someone help me in testing and fixing those so that PPC can migrate > to new/common cacheinfo infrastructure. This resend is rebased on v4.0-rc1 Doesn't build for me. arch/powerpc/platforms/pseries/suspend.c:29:36: fatal error: ../../kernel/cacheinfo.h: No such file or directory #include "../../kernel/cacheinfo.h" Anshuman must have worked around that somehow to test it previously? Removing the include doesn't fix it, it needs cacheinfo_cpu_on/offline(). cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F7A51A03DB for ; Tue, 31 Mar 2015 21:56:37 +1100 (AEDT) In-Reply-To: <1424715500-21725-1-git-send-email-sudeep.holla@arm.com> To: Sudeep Holla , linux-kernel@vger.kernel.org, Anshuman Khandual From: Michael Ellerman Subject: Re: [RFC/RFT, RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure Message-Id: <20150331105637.39B451400DE@ozlabs.org> Date: Tue, 31 Mar 2015 21:56:37 +1100 (AEDT) Cc: Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Sudeep Holla List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2015-23-02 at 18:18:20 UTC, Sudeep Holla wrote: > This patch removes the redundant sysfs cacheinfo code by reusing > the newly introduced generic cacheinfo infrastructure through the > commit 246246cbde5e ("drivers: base: support cpu cache information > interface to userspace via sysfs") > > Signed-off-by: Sudeep Holla > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Anshuman Khandual > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/kernel/cacheinfo.c | 811 +++++----------------------------------- > arch/powerpc/kernel/cacheinfo.h | 8 - > arch/powerpc/kernel/sysfs.c | 12 +- > 3 files changed, 91 insertions(+), 740 deletions(-) > delete mode 100644 arch/powerpc/kernel/cacheinfo.h > > Hi, > > This patch is not tested. Last time Anshuman tested, he had seen issues. > The core driver has changed a lot after that. Since PPC depends a lot > on DT for cache information, there might be issues in the core later > which I could not identify with ARM/ARM64. It would be much appreciable > if someone help me in testing and fixing those so that PPC can migrate > to new/common cacheinfo infrastructure. This resend is rebased on v4.0-rc1 Doesn't build for me. arch/powerpc/platforms/pseries/suspend.c:29:36: fatal error: ../../kernel/cacheinfo.h: No such file or directory #include "../../kernel/cacheinfo.h" Anshuman must have worked around that somehow to test it previously? Removing the include doesn't fix it, it needs cacheinfo_cpu_on/offline(). cheers