From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbCaQKY (ORCPT ); Tue, 31 Mar 2015 12:10:24 -0400 Received: from verein.lst.de ([213.95.11.211]:55952 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbCaQKX (ORCPT ); Tue, 31 Mar 2015 12:10:23 -0400 Date: Tue, 31 Mar 2015 18:10:21 +0200 From: Christoph Hellwig To: Boaz Harrosh Cc: Boaz Harrosh , Christoph Hellwig , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, ross.zwisler@linux.intel.com, axboe@kernel.dk Subject: Re: [RFC] SQUASHME: pmem: Split up pmem_probe from pmem_alloc Message-ID: <20150331161021.GB1152@lst.de> References: <1427358764-6126-1-git-send-email-hch@lst.de> <55143A8B.2060304@plexistor.com> <20150331092526.GA25958@lst.de> <551A762A.7090307@plexistor.com> <551AAD5B.4020104@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551AAD5B.4020104@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 05:21:15PM +0300, Boaz Harrosh wrote: > -static int pmem_probe(struct platform_device *pdev) > +static int pmem_alloc(struct resource *res, struct device *dev, > + struct pmem_device **o_pmem) > { please return the pmem device or an ERR_PTR() here. Except for that it looks fine for me, and it's exactly what we'd export for your PCIe device which would get an almost trivial pci_driver wrapper around it.