From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755104AbbCaQGB (ORCPT ); Tue, 31 Mar 2015 12:06:01 -0400 Received: from foss.arm.com ([217.140.101.70]:35906 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754271AbbCaQF6 (ORCPT ); Tue, 31 Mar 2015 12:05:58 -0400 Date: Tue, 31 Mar 2015 17:05:30 +0100 From: Marc Zyngier To: Paolo Bonzini Cc: Joe Perches , "linux-kernel@vger.kernel.org" , Christoffer Dall , Gleb Natapov , Tony Lindgren , Russell King , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "linux-omap@vger.kernel.org" Subject: Re: [PATCH 01/25] arm: Use bool function return values of true/false not 1/0 Message-ID: <20150331170530.0479b9ab@arm.com> In-Reply-To: <551AC424.9010802@redhat.com> References: <912ed0ebae3c6a16f58b1452d5ce9226681bc8df.1427759009.git.joe@perches.com> <551AC424.9010802@redhat.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Mar 2015 16:58:28 +0100 Paolo Bonzini wrote: > On 31/03/2015 01:45, Joe Perches wrote: > > Use the normal return values for bool functions > > > > Signed-off-by: Joe Perches > > --- > > arch/arm/include/asm/dma-mapping.h | 8 ++++---- > > arch/arm/include/asm/kvm_emulate.h | 2 +- > > arch/arm/mach-omap2/powerdomain.c | 14 +++++++------- > > 3 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h > > index b52101d..166e1e1 100644 > > --- a/arch/arm/include/asm/dma-mapping.h > > +++ b/arch/arm/include/asm/dma-mapping.h > > @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > > u64 limit, mask; > > > > if (!dev->dma_mask) > > - return 0; > > + return false; > > > > mask = *dev->dma_mask; > > > > limit = (mask + 1) & ~mask; > > if (limit && size > limit) > > - return 0; > > + return false; > > > > if ((addr | (addr + size - 1)) & ~mask) > > - return 0; > > + return false; > > > > - return 1; > > + return true; > > } > > > > static inline void dma_mark_clean(void *addr, size_t size) { } > > diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h > > index a9c80a2..ad200a0 100644 > > --- a/arch/arm/include/asm/kvm_emulate.h > > +++ b/arch/arm/include/asm/kvm_emulate.h > > @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr) > > > > static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu) > > { > > - return 1; > > + return true; > > } > > > > static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu) > > diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c > > index 78af6d8..897f9fb 100644 > > --- a/arch/arm/mach-omap2/powerdomain.c > > +++ b/arch/arm/mach-omap2/powerdomain.c > > @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm) > > */ > > bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm) > > { > > - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0; > > + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR); > > } > > > > int pwrdm_state_switch_nolock(struct powerdomain *pwrdm) > > @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm) > > if (!pwrdm) { > > pr_debug("powerdomain: %s: invalid powerdomain pointer\n", > > __func__); > > - return 1; > > + return true; > > } > > > > if (pwrdm->pwrsts & PWRSTS_OFF) > > - return 1; > > + return true; > > > > if (pwrdm->pwrsts & PWRSTS_RET) { > > if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF) > > - return 1; > > + return true; > > > > for (i = 0; i < pwrdm->banks; i++) > > if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF) > > - return 1; > > + return true; > > } > > > > for (i = 0; i < pwrdm->banks; i++) > > if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF) > > - return 1; > > + return true; > > > > - return 0; > > + return false; > > } > > > > Marc/Christoffer, please pick this up yourself. Given that it touches a range of completely unrelated files, for the KVM part: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH 01/25] arm: Use bool function return values of true/false not 1/0 Date: Tue, 31 Mar 2015 17:05:30 +0100 Message-ID: <20150331170530.0479b9ab@arm.com> References: <912ed0ebae3c6a16f58b1452d5ce9226681bc8df.1427759009.git.joe@perches.com> <551AC424.9010802@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <551AC424.9010802@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Paolo Bonzini Cc: Russell King , "kvm@vger.kernel.org" , Gleb Natapov , "linux-kernel@vger.kernel.org" , Tony Lindgren , "linux-arm-kernel@lists.infradead.org" , Joe Perches , "linux-omap@vger.kernel.org" , "kvmarm@lists.cs.columbia.edu" List-Id: linux-omap@vger.kernel.org On Tue, 31 Mar 2015 16:58:28 +0100 Paolo Bonzini wrote: > On 31/03/2015 01:45, Joe Perches wrote: > > Use the normal return values for bool functions > > > > Signed-off-by: Joe Perches > > --- > > arch/arm/include/asm/dma-mapping.h | 8 ++++---- > > arch/arm/include/asm/kvm_emulate.h | 2 +- > > arch/arm/mach-omap2/powerdomain.c | 14 +++++++------- > > 3 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h > > index b52101d..166e1e1 100644 > > --- a/arch/arm/include/asm/dma-mapping.h > > +++ b/arch/arm/include/asm/dma-mapping.h > > @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > > u64 limit, mask; > > > > if (!dev->dma_mask) > > - return 0; > > + return false; > > > > mask = *dev->dma_mask; > > > > limit = (mask + 1) & ~mask; > > if (limit && size > limit) > > - return 0; > > + return false; > > > > if ((addr | (addr + size - 1)) & ~mask) > > - return 0; > > + return false; > > > > - return 1; > > + return true; > > } > > > > static inline void dma_mark_clean(void *addr, size_t size) { } > > diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h > > index a9c80a2..ad200a0 100644 > > --- a/arch/arm/include/asm/kvm_emulate.h > > +++ b/arch/arm/include/asm/kvm_emulate.h > > @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr) > > > > static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu) > > { > > - return 1; > > + return true; > > } > > > > static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu) > > diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c > > index 78af6d8..897f9fb 100644 > > --- a/arch/arm/mach-omap2/powerdomain.c > > +++ b/arch/arm/mach-omap2/powerdomain.c > > @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm) > > */ > > bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm) > > { > > - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0; > > + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR); > > } > > > > int pwrdm_state_switch_nolock(struct powerdomain *pwrdm) > > @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm) > > if (!pwrdm) { > > pr_debug("powerdomain: %s: invalid powerdomain pointer\n", > > __func__); > > - return 1; > > + return true; > > } > > > > if (pwrdm->pwrsts & PWRSTS_OFF) > > - return 1; > > + return true; > > > > if (pwrdm->pwrsts & PWRSTS_RET) { > > if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF) > > - return 1; > > + return true; > > > > for (i = 0; i < pwrdm->banks; i++) > > if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF) > > - return 1; > > + return true; > > } > > > > for (i = 0; i < pwrdm->banks; i++) > > if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF) > > - return 1; > > + return true; > > > > - return 0; > > + return false; > > } > > > > Marc/Christoffer, please pick this up yourself. Given that it touches a range of completely unrelated files, for the KVM part: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Tue, 31 Mar 2015 17:05:30 +0100 Subject: [PATCH 01/25] arm: Use bool function return values of true/false not 1/0 In-Reply-To: <551AC424.9010802@redhat.com> References: <912ed0ebae3c6a16f58b1452d5ce9226681bc8df.1427759009.git.joe@perches.com> <551AC424.9010802@redhat.com> Message-ID: <20150331170530.0479b9ab@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 31 Mar 2015 16:58:28 +0100 Paolo Bonzini wrote: > On 31/03/2015 01:45, Joe Perches wrote: > > Use the normal return values for bool functions > > > > Signed-off-by: Joe Perches > > --- > > arch/arm/include/asm/dma-mapping.h | 8 ++++---- > > arch/arm/include/asm/kvm_emulate.h | 2 +- > > arch/arm/mach-omap2/powerdomain.c | 14 +++++++------- > > 3 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/arch/arm/include/asm/dma-mapping.h b/arch/arm/include/asm/dma-mapping.h > > index b52101d..166e1e1 100644 > > --- a/arch/arm/include/asm/dma-mapping.h > > +++ b/arch/arm/include/asm/dma-mapping.h > > @@ -151,18 +151,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > > u64 limit, mask; > > > > if (!dev->dma_mask) > > - return 0; > > + return false; > > > > mask = *dev->dma_mask; > > > > limit = (mask + 1) & ~mask; > > if (limit && size > limit) > > - return 0; > > + return false; > > > > if ((addr | (addr + size - 1)) & ~mask) > > - return 0; > > + return false; > > > > - return 1; > > + return true; > > } > > > > static inline void dma_mark_clean(void *addr, size_t size) { } > > diff --git a/arch/arm/include/asm/kvm_emulate.h b/arch/arm/include/asm/kvm_emulate.h > > index a9c80a2..ad200a0 100644 > > --- a/arch/arm/include/asm/kvm_emulate.h > > +++ b/arch/arm/include/asm/kvm_emulate.h > > @@ -51,7 +51,7 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr) > > > > static inline bool vcpu_mode_is_32bit(struct kvm_vcpu *vcpu) > > { > > - return 1; > > + return true; > > } > > > > static inline unsigned long *vcpu_pc(struct kvm_vcpu *vcpu) > > diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c > > index 78af6d8..897f9fb 100644 > > --- a/arch/arm/mach-omap2/powerdomain.c > > +++ b/arch/arm/mach-omap2/powerdomain.c > > @@ -950,7 +950,7 @@ int pwrdm_disable_hdwr_sar(struct powerdomain *pwrdm) > > */ > > bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm) > > { > > - return (pwrdm && pwrdm->flags & PWRDM_HAS_HDWR_SAR) ? 1 : 0; > > + return pwrdm && (pwrdm->flags & PWRDM_HAS_HDWR_SAR); > > } > > > > int pwrdm_state_switch_nolock(struct powerdomain *pwrdm) > > @@ -1185,24 +1185,24 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm) > > if (!pwrdm) { > > pr_debug("powerdomain: %s: invalid powerdomain pointer\n", > > __func__); > > - return 1; > > + return true; > > } > > > > if (pwrdm->pwrsts & PWRSTS_OFF) > > - return 1; > > + return true; > > > > if (pwrdm->pwrsts & PWRSTS_RET) { > > if (pwrdm->pwrsts_logic_ret & PWRSTS_OFF) > > - return 1; > > + return true; > > > > for (i = 0; i < pwrdm->banks; i++) > > if (pwrdm->pwrsts_mem_ret[i] & PWRSTS_OFF) > > - return 1; > > + return true; > > } > > > > for (i = 0; i < pwrdm->banks; i++) > > if (pwrdm->pwrsts_mem_on[i] & PWRSTS_OFF) > > - return 1; > > + return true; > > > > - return 0; > > + return false; > > } > > > > Marc/Christoffer, please pick this up yourself. Given that it touches a range of completely unrelated files, for the KVM part: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.