From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Wang Nan <wangnan0@huawei.com>,
jolsa@kernel.org, namhyung@kernel.org, mingo@redhat.com,
lizefan@huawei.com, pi3orama@163.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] perf tools: introduce machine_map_new to merge mmap/mmap2 processing code.
Date: Wed, 1 Apr 2015 11:58:27 -0300 [thread overview]
Message-ID: <20150401145827.GB4549@kernel.org> (raw)
In-Reply-To: <20150401121853.GB10820@krava.brq.redhat.com>
Em Wed, Apr 01, 2015 at 02:18:53PM +0200, Jiri Olsa escreveu:
> On Wed, Apr 01, 2015 at 10:33:13AM +0000, Wang Nan wrote:
> > Create a machine_map_new() and merge mapping code in
> > machine__process_mmap2_event() and machine__process_mmap_event()
> > together. This patch is a preparation for following map adjustment
> > patches.
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> > +static int machine_map_new(struct machine *machine, u64 start, u64 len,
> > + u64 pgoff, u32 pid, u32 d_maj, u32 d_min, u64 ino,
> > + u64 ino_gen, u32 prot, u32 flags, char *filename,
> > + enum map_type type, struct thread *thread)
> the name style for this should be more like 'machine__new_map'
> I think Arnaldo will chime in.. ;-)
Right, I wonder if this is a function that is about 'maps' or 'machines'
mostly, that would say what prefix should be used, if map__ or
machine__, still need to review this patchset.
Just give a really quick lock, eyebrows raised, even more complexity for
the symbol layer, wonder if this can't be simplified...
- Arnaldo
next prev parent reply other threads:[~2015-04-01 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 10:33 [PATCH 0/4] perf tools: introduce --map-adjustment Wang Nan
2015-04-01 10:33 ` [PATCH 1/4] perf tools: unwind: ensure unwind hooks return negative errorno Wang Nan
2015-04-01 12:12 ` Jiri Olsa
2015-04-01 12:41 ` Wang Nan
2015-04-07 8:30 ` Wang Nan
2015-04-01 10:33 ` [PATCH 2/4] perf tools: introduce machine_map_new to merge mmap/mmap2 processing code Wang Nan
2015-04-01 12:18 ` Jiri Olsa
2015-04-01 14:58 ` Arnaldo Carvalho de Melo [this message]
2015-04-01 10:33 ` [PATCH 3/4] perf tools: report: introduce --map-adjustment argument Wang Nan
2015-04-01 13:21 ` Jiri Olsa
2015-04-02 1:15 ` Wang Nan
2015-04-01 14:23 ` pi3orama
2015-04-01 10:33 ` [PATCH 4/4] perf tools: unwinding: try to read from map_adj for a unmapped address Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401145827.GB4549@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.