From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked. Date: Wed, 1 Apr 2015 12:07:44 -0400 Message-ID: <20150401160744.GR9974@htj.duckdns.org> References: <1427787309-1601-1-git-send-email-peter.griffin@linaro.org> <1427787309-1601-4-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1427787309-1601-4-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Griffin Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, maxime.coquelin-qxv4g6HH51o@public.gmane.org, patrice.chotard-qxv4g6HH51o@public.gmane.org, srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-ide@vger.kernel.org On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote: > Currently the ahci_st driver will hang the system on probe, as the > st_configure_oob function does some register writes before the IP > is clocked. This patch moves the function call to after > ahci_platform_enable_resources (which enables the IP clock), and > resolves the hang. > > Addtionally st_ahci_configure_oob should be called in the st_ahci_resume > function, so we also rectify that ensuring it is also called after > the IP clock has been enabled. > > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > Acked-by: Maxime Coquelin Applied 1, 3 to libata/for-4.1. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752372AbbDAQHu (ORCPT ); Wed, 1 Apr 2015 12:07:50 -0400 Received: from mail-qc0-f182.google.com ([209.85.216.182]:34374 "EHLO mail-qc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbbDAQHs (ORCPT ); Wed, 1 Apr 2015 12:07:48 -0400 Date: Wed, 1 Apr 2015 12:07:44 -0400 From: Tejun Heo To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked. Message-ID: <20150401160744.GR9974@htj.duckdns.org> References: <1427787309-1601-1-git-send-email-peter.griffin@linaro.org> <1427787309-1601-4-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427787309-1601-4-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote: > Currently the ahci_st driver will hang the system on probe, as the > st_configure_oob function does some register writes before the IP > is clocked. This patch moves the function call to after > ahci_platform_enable_resources (which enables the IP clock), and > resolves the hang. > > Addtionally st_ahci_configure_oob should be called in the st_ahci_resume > function, so we also rectify that ensuring it is also called after > the IP clock has been enabled. > > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > Acked-by: Maxime Coquelin Applied 1, 3 to libata/for-4.1. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: tj@kernel.org (Tejun Heo) Date: Wed, 1 Apr 2015 12:07:44 -0400 Subject: [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked. In-Reply-To: <1427787309-1601-4-git-send-email-peter.griffin@linaro.org> References: <1427787309-1601-1-git-send-email-peter.griffin@linaro.org> <1427787309-1601-4-git-send-email-peter.griffin@linaro.org> Message-ID: <20150401160744.GR9974@htj.duckdns.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote: > Currently the ahci_st driver will hang the system on probe, as the > st_configure_oob function does some register writes before the IP > is clocked. This patch moves the function call to after > ahci_platform_enable_resources (which enables the IP clock), and > resolves the hang. > > Addtionally st_ahci_configure_oob should be called in the st_ahci_resume > function, so we also rectify that ensuring it is also called after > the IP clock has been enabled. > > Signed-off-by: Peter Griffin > Acked-by: Lee Jones > Acked-by: Maxime Coquelin Applied 1, 3 to libata/for-4.1. Thanks. -- tejun