Re: [RFC][PATCH] perf tools: unify perf_event_attr printing

From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Ahern <dsahern@gmail.com>,
	Stephane Eranian <eranian@google.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	John Stultz <john.stultz@linaro.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH] perf tools: unify perf_event_attr printing
Date: Thu, 2 Apr 2015 11:19:47 +0200	[thread overview]
Message-ID: <20150402091947.GA10024@krava.brq.redhat.com> (raw)
In-Reply-To: <20150401162638.GN24151@twins.programming.kicks-ass.net>

On Wed, Apr 01, 2015 at 06:26:38PM +0200, Peter Zijlstra wrote:

SNIP

> -	ret += PRINT_ATTR_U32(wakeup_events);
> -	ret += PRINT_ATTR_U32(wakeup_watermark);
> -	ret += PRINT_ATTR_X32(bp_type);
> -	ret += PRINT_ATTR_X64(bp_addr);
> -	ret += PRINT_ATTR_X64(config1);
> -	ret += PRINT_ATTR_U64(bp_len);
> -	ret += PRINT_ATTR_X64(config2);
> -	ret += PRINT_ATTR_X64(branch_sample_type);
> -	ret += PRINT_ATTR_X64(sample_regs_user);
> -	ret += PRINT_ATTR_U32(sample_stack_user);
> -	ret += PRINT_ATTR_U32(clockid);
> -	ret += PRINT_ATTR_X64(sample_regs_intr);
> +#define PRINT_ATTR(_n, _f, _p)			\
> +do {						\
> +	if (attr->_f) {				\
> +	ret += fprintf(fp, "  %-32s ", _n);	\
> +	ret += _p(fp, attr->_f);		\
> +	ret += fprintf(fp, "\n");		\

missing indent ;-) other it seems ok

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka