From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbbDBQrS (ORCPT ); Thu, 2 Apr 2015 12:47:18 -0400 Received: from mail.skyhub.de ([78.46.96.112]:47497 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbDBQrQ (ORCPT ); Thu, 2 Apr 2015 12:47:16 -0400 Date: Thu, 2 Apr 2015 18:45:15 +0200 From: Borislav Petkov To: Quentin Casasnovas Cc: X86 ML , LKML , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Oleg Nesterov , Andy Lutomirski Subject: Re: [PATCH] x86/xsave: Robustify and merge macros Message-ID: <20150402164515.GF3483@pd.tnic> References: <1427980282-25929-1-git-send-email-bp@alien8.de> <20150402155210.GB6703@chrystal.uk.oracle.com> <20150402161259.GE3483@pd.tnic> <20150402163340.GB14902@chrystal.uk.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150402163340.GB14902@chrystal.uk.oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 06:33:40PM +0200, Quentin Casasnovas wrote: > I would personnaly add it to the non _booting() variants as well to make > sure the alternative instructions _are_ applied, since otherwise that would > probably cause random failures to restore the xsaveopt/xsaves context > previously saved. This is probably the only reason why I should keep them: so that there are no mismatched save and restore uses. But this needs to be cleaned up properly, maybe the two even merged. It would need more analysis at the callsites. Definitely future work. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --