From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbbDCIuF (ORCPT ); Fri, 3 Apr 2015 04:50:05 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:33208 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbbDCIuB (ORCPT ); Fri, 3 Apr 2015 04:50:01 -0400 Date: Fri, 3 Apr 2015 10:49:56 +0200 From: Ingo Molnar To: Wang Nan Cc: jolsa@redhat.com, namhyung@kernel.org, jolsa@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [PATCH] perf: kmaps: enforce usage of kmaps to protect futher bugs. Message-ID: <20150403084956.GA19328@gmail.com> References: <20150403064822.GB29383@gmail.com> <1428050877-54093-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428050877-54093-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Wang Nan wrote: > This patch add checkings on every place where uses map__kmap and get > kmaps from struct kmap. Error messages are added at map__kmap to warn > invalud accessing of kmap (for the case of !map->dso->kernel, kmap(map) > is not exists at all). Also, introduces map__kmaps() to warn > uninitialized kmaps. > > Signed-off-by: Wang Nan Reviewed-by: Ingo Molnar Thanks, Ingo