From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbbDCNoz (ORCPT ); Fri, 3 Apr 2015 09:44:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41186 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbbDCNov (ORCPT ); Fri, 3 Apr 2015 09:44:51 -0400 Date: Fri, 3 Apr 2015 15:44:46 +0200 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: "Lad, Prabhakar" , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "usb: host/sl811-hcd: fix sparse warning" Message-ID: <20150403134446.GA10645@kroah.com> References: <1427973341-1019-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427973341-1019-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 04:45:40PM +0530, Sudip Mukherjee wrote: > This reverts commit <1dc6120ef7f003305d99ef12f598a6b05eacc38c>. > > if we are doing allyesconfig on x86_64, build fails with error: > drivers/built-in.o: In function `sl811_cs_probe': > sl811_cs.c:(.text+0x1d4612e): undefined reference to `sl811h_driver' > > this commit has declared sl811h_driver as static but it was being > accessed from sl811_cs.c. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/host/sl811-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Someone else sent this patch in a few days before you did, sorry. greg k-h