From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbbDCQOk (ORCPT ); Fri, 3 Apr 2015 12:14:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55173 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbbDCQOf (ORCPT ); Fri, 3 Apr 2015 12:14:35 -0400 Date: Fri, 3 Apr 2015 13:14:38 -0300 From: Arnaldo Carvalho de Melo To: Peter Zijlstra Cc: Adrian Hunter , Jiri Olsa , David Ahern , Stephane Eranian , Thomas Gleixner , Linus Torvalds , LKML , John Stultz , "H. Peter Anvin" , Andrew Morton , Ingo Molnar Subject: Re: [RFC][PATCH] perf tools: unify perf_event_attr printing Message-ID: <20150403161438.GC2500@redhat.com> References: <20150401165250.GA22417@krava.brq.redhat.com> <551D0581.3070100@intel.com> <20150402115934.GU23123@twins.programming.kicks-ass.net> <20150403161147.GB2500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150403161147.GB2500@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Apr 03, 2015 at 01:11:47PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Apr 02, 2015 at 01:59:34PM +0200, Peter Zijlstra escreveu: > > On Thu, Apr 02, 2015 at 12:01:53PM +0300, Adrian Hunter wrote: > > > But personally I think the "include" approach is too ugly. I would just > > > add a function instead. Something like: > > > > You've not stared at the kernel tracepoint code long enough ;-) > > > > Something like so then? > > Ok, this one seems to have gotten acks from Ingo, Jiri and Adrian, but > doesn't apply because it needs that clock_id one first, searching the > situation of that part... Hey Peter, would you be so kind and resubmit this (at least) two part series? I.e. the first one adding the clockid and the second, with the consolidation of the perf_event_attr printing? - Arnaldo