From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbbDCVhb (ORCPT ); Fri, 3 Apr 2015 17:37:31 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:51129 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751430AbbDCVh2 (ORCPT ); Fri, 3 Apr 2015 17:37:28 -0400 Date: Sat, 4 Apr 2015 00:36:55 +0300 From: Sakari Ailus To: Pavel Machek Cc: Andrew Morton , pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, galak@codeaurora.org, bcousson@baylibre.com, m.chehab@samsung.com, devicetree@vger.kernel.org Subject: Re: [PATCHv6] media: i2c/adp1653: Documentation for devicetree support for adp1653 Message-ID: <20150403213655.GO20756@valkosipuli.retiisi.org.uk> References: <20150402143846.GA11687@amd> <20150402203417.GA6336@amd> <20150403083353.GA21070@amd> <20150403113216.GK20756@valkosipuli.retiisi.org.uk> <20150403202624.GA4308@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150403202624.GA4308@amd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On Fri, Apr 03, 2015 at 10:26:24PM +0200, Pavel Machek wrote: > > Documentation for adp1653 binding. > > --- > > > Please split this as Javier suggested. I'd think both could go through > > the media-tree unless someone objects. > > Please apply. > > > > + - power-gpios: Reference to the GPIO that controls the power for the chip. > > > > You're using power-gpios in documentation only. > > Which is ok, because generic code adds "-gpios" itself. > > > The spec refers to this by "EN". How about "en-gpios" instead? This > > definitely isn't about power, but about resetting the chip. It gets the > > power through another pin. > > It controls power of the chip. Noone gets _power_ through gpios, > hopefully. Yes, I can rename it. "en-gpios" is too ugly to > live. Sebastian suggested "enable". Hope that's okay with you. "enable-gpios" sounds fine for me. > > Pavel > > new file mode 100644 > index 0000000..da9934a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/adp1653.txt > @@ -0,0 +1,37 @@ > +* Analog Devices ADP1653 flash LED driver > + > +Required Properties: > + > + - compatible: Must contain be "adi,adp1653" > + > + - reg: I2C slave address > + > + - power-gpios: Reference to the GPIO that controls the power for the chip. > + > +There are two LED outputs available - flash and indicator. One LED is > +represented by one child node, nodes need to be named "flash" and "indicator". > + > +Required properties of the LED child node: > +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt > + > +Required properties of the flash LED child node: > + > +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt > +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt > + > +Example: > + > + adp1653: led-controller@30 { > + compatible = "adi,adp1653"; > + reg = <0x30>; > + power-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ > + > + flash { > + flash-timeout-us = <500000>; > + flash-max-microamp = <320000>; > + max-microamp = <50000>; > + }; > + indicator { > + max-microamp = <17500>; > + }; > + }; > -- Regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk From mboxrd@z Thu Jan 1 00:00:00 1970 From: sakari.ailus@iki.fi (Sakari Ailus) Date: Sat, 4 Apr 2015 00:36:55 +0300 Subject: [PATCHv6] media: i2c/adp1653: Documentation for devicetree support for adp1653 In-Reply-To: <20150403202624.GA4308@amd> References: <20150402143846.GA11687@amd> <20150402203417.GA6336@amd> <20150403083353.GA21070@amd> <20150403113216.GK20756@valkosipuli.retiisi.org.uk> <20150403202624.GA4308@amd> Message-ID: <20150403213655.GO20756@valkosipuli.retiisi.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Pavel, On Fri, Apr 03, 2015 at 10:26:24PM +0200, Pavel Machek wrote: > > Documentation for adp1653 binding. > > --- > > > Please split this as Javier suggested. I'd think both could go through > > the media-tree unless someone objects. > > Please apply. > > > > + - power-gpios: Reference to the GPIO that controls the power for the chip. > > > > You're using power-gpios in documentation only. > > Which is ok, because generic code adds "-gpios" itself. > > > The spec refers to this by "EN". How about "en-gpios" instead? This > > definitely isn't about power, but about resetting the chip. It gets the > > power through another pin. > > It controls power of the chip. Noone gets _power_ through gpios, > hopefully. Yes, I can rename it. "en-gpios" is too ugly to > live. Sebastian suggested "enable". Hope that's okay with you. "enable-gpios" sounds fine for me. > > Pavel > > new file mode 100644 > index 0000000..da9934a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/adp1653.txt > @@ -0,0 +1,37 @@ > +* Analog Devices ADP1653 flash LED driver > + > +Required Properties: > + > + - compatible: Must contain be "adi,adp1653" > + > + - reg: I2C slave address > + > + - power-gpios: Reference to the GPIO that controls the power for the chip. > + > +There are two LED outputs available - flash and indicator. One LED is > +represented by one child node, nodes need to be named "flash" and "indicator". > + > +Required properties of the LED child node: > +- max-microamp : see Documentation/devicetree/bindings/leds/common.txt > + > +Required properties of the flash LED child node: > + > +- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt > +- flash-timeout-us : see Documentation/devicetree/bindings/leds/common.txt > + > +Example: > + > + adp1653: led-controller at 30 { > + compatible = "adi,adp1653"; > + reg = <0x30>; > + power-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>; /* 88 */ > + > + flash { > + flash-timeout-us = <500000>; > + flash-max-microamp = <320000>; > + max-microamp = <50000>; > + }; > + indicator { > + max-microamp = <17500>; > + }; > + }; > -- Regards, Sakari Ailus e-mail: sakari.ailus at iki.fi XMPP: sailus at retiisi.org.uk