From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Date: Sat, 04 Apr 2015 12:53:04 +0000 Subject: Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h Message-Id: <20150404125303.GE4027@n2100.arm.linux.org.uk> List-Id: References: <20150403171149.GC13898@n2100.arm.linux.org.uk> <87lhi8rrmd.fsf@free.fr> In-Reply-To: <87lhi8rrmd.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robert Jarzmik Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org, Sekhar Nori , Kevin Hilman , Tony Lindgren , Daniel Mack , Haojian Zhuang On Sat, Apr 04, 2015 at 02:43:22PM +0200, Robert Jarzmik wrote: > Russell King writes: > > > clk_add_alias() is provided by clkdev, and is not part of the clk API. > > Howver, it is prototyped in two locations: linux/clkdev.h and > > linux/clk.h. This is a mess. Get rid of the redundant and unnecessary > > version in linux/clk.h. > > > > Signed-off-by: Russell King > Tested-by: Robert Jarzmik > > Actually, this serie fixes a regression I've seen in linux-next, and > which was triggering the Oops in [1] on lubbock. With your serie, the > kernel boots fine. Yes, this series does fix a regression - I mentioned that the per-user clk patches broke quite a bit of this code in the cover to the series. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from pandora.arm.linux.org.uk ([78.32.30.218]:35515 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbbDDMxS (ORCPT ); Sat, 4 Apr 2015 08:53:18 -0400 Date: Sat, 4 Apr 2015 13:53:04 +0100 From: Russell King - ARM Linux To: Robert Jarzmik Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sh@vger.kernel.org, Sekhar Nori , Kevin Hilman , Tony Lindgren , Daniel Mack , Haojian Zhuang Subject: Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h Message-ID: <20150404125303.GE4027@n2100.arm.linux.org.uk> References: <20150403171149.GC13898@n2100.arm.linux.org.uk> <87lhi8rrmd.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lhi8rrmd.fsf@free.fr> Sender: linux-media-owner@vger.kernel.org List-ID: On Sat, Apr 04, 2015 at 02:43:22PM +0200, Robert Jarzmik wrote: > Russell King writes: > > > clk_add_alias() is provided by clkdev, and is not part of the clk API. > > Howver, it is prototyped in two locations: linux/clkdev.h and > > linux/clk.h. This is a mess. Get rid of the redundant and unnecessary > > version in linux/clk.h. > > > > Signed-off-by: Russell King > Tested-by: Robert Jarzmik > > Actually, this serie fixes a regression I've seen in linux-next, and > which was triggering the Oops in [1] on lubbock. With your serie, the > kernel boots fine. Yes, this series does fix a regression - I mentioned that the per-user clk patches broke quite a bit of this code in the cover to the series. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sat, 4 Apr 2015 13:53:04 +0100 Subject: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h In-Reply-To: <87lhi8rrmd.fsf@free.fr> References: <20150403171149.GC13898@n2100.arm.linux.org.uk> <87lhi8rrmd.fsf@free.fr> Message-ID: <20150404125303.GE4027@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Apr 04, 2015 at 02:43:22PM +0200, Robert Jarzmik wrote: > Russell King writes: > > > clk_add_alias() is provided by clkdev, and is not part of the clk API. > > Howver, it is prototyped in two locations: linux/clkdev.h and > > linux/clk.h. This is a mess. Get rid of the redundant and unnecessary > > version in linux/clk.h. > > > > Signed-off-by: Russell King > Tested-by: Robert Jarzmik > > Actually, this serie fixes a regression I've seen in linux-next, and > which was triggering the Oops in [1] on lubbock. With your serie, the > kernel boots fine. Yes, this series does fix a regression - I mentioned that the per-user clk patches broke quite a bit of this code in the cover to the series. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.