From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbbDFBF5 (ORCPT ); Sun, 5 Apr 2015 21:05:57 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:34394 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbbDFBFy (ORCPT ); Sun, 5 Apr 2015 21:05:54 -0400 Date: Sun, 5 Apr 2015 18:05:50 -0700 From: Brian Norris To: Nicholas Mc Guire Cc: David Woodhouse , Aaron Sierra , Joe Schultz , Wolfram Sang , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time conversion Message-ID: <20150406010550.GI2677@norris-Latitude-E6410> References: <1426245828-15640-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426245828-15640-1-git-send-email-hofrat@osadl.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 07:23:47AM -0400, Nicholas Mc Guire wrote: > This is only an API consolidation and should make things more readable > it replaces var * HZ / 1000 by msecs_to_jiffies(var) which helps readability > and also handles all corner-cases properly. > > Signed-off-by: Nicholas Mc Guire Pushed to l2-mtd.git. I'm not sure the objections about an extra function call are important right now; if they are, then it shouldn't be too hard to patch in a __builtin_constant_p() variant of msecs_to_jiffies(), as Joe suggested. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YevUV-0002yz-8L for linux-mtd@lists.infradead.org; Mon, 06 Apr 2015 01:06:16 +0000 Received: by patj18 with SMTP id j18so28593201pat.2 for ; Sun, 05 Apr 2015 18:05:53 -0700 (PDT) Date: Sun, 5 Apr 2015 18:05:50 -0700 From: Brian Norris To: Nicholas Mc Guire Subject: Re: [PATCH] mtd: fsl_ifc_nand: use msecs_to_jiffies for time conversion Message-ID: <20150406010550.GI2677@norris-Latitude-E6410> References: <1426245828-15640-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426245828-15640-1-git-send-email-hofrat@osadl.org> Cc: Wolfram Sang , linux-kernel@vger.kernel.org, Joe Schultz , linux-mtd@lists.infradead.org, Aaron Sierra , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Mar 13, 2015 at 07:23:47AM -0400, Nicholas Mc Guire wrote: > This is only an API consolidation and should make things more readable > it replaces var * HZ / 1000 by msecs_to_jiffies(var) which helps readability > and also handles all corner-cases properly. > > Signed-off-by: Nicholas Mc Guire Pushed to l2-mtd.git. I'm not sure the objections about an extra function call are important right now; if they are, then it shouldn't be too hard to patch in a __builtin_constant_p() variant of msecs_to_jiffies(), as Joe suggested. Brian