From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123AbbDGC1q (ORCPT ); Mon, 6 Apr 2015 22:27:46 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:33772 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752988AbbDGC1o (ORCPT ); Mon, 6 Apr 2015 22:27:44 -0400 Date: Mon, 6 Apr 2015 19:27:52 -0700 From: Eduardo Valentin To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , linux-kernel@vger.kernel.org, Stephen Warren , Mikko Perttunen , kernel@pengutronix.de, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/13] thermal: of: streamline .get_temp callbacks Message-ID: <20150407022750.GF4648@localhost.localdomain> References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-8-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="924gEkU1VlJlwnwX" Content-Disposition: inline In-Reply-To: <1427385240-6086-8-git-send-email-s.hauer@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --924gEkU1VlJlwnwX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 26, 2015 at 04:53:54PM +0100, Sascha Hauer wrote: > In the thermal framework it was decided that temperatures can't > be negative, so let the .get_temp callback in struct > thermal_zone_of_device_ops take an unsigned long pointer for > the temperature like the .get_temp callback in > struct thermal_zone_device_ops does. This change is required. However, better we move to the direction of using signed type for temperature. However, we want to have int instead of long though. >=20 > Signed-off-by: Sascha Hauer > --- > drivers/hwmon/lm75.c | 2 +- > drivers/hwmon/ntc_thermistor.c | 2 +- > drivers/hwmon/tmp102.c | 2 +- > drivers/input/touchscreen/sun4i-ts.c | 2 +- > drivers/thermal/rockchip_thermal.c | 2 +- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > drivers/thermal/tegra_soctherm.c | 2 +- > drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 2 +- > include/linux/thermal.h | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index fe41d5a..9df3ca3 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -104,7 +104,7 @@ static inline long lm75_reg_to_mc(s16 temp, u8 resolu= tion) > =20 > /* sysfs attributes for hwmon */ > =20 > -static int lm75_read_temp(void *dev, long *temp) > +static int lm75_read_temp(void *dev, unsigned long *temp) > { > struct lm75_data *data =3D lm75_update_device(dev); > =20 > diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermisto= r.c > index 112e4d4..12cb333 100644 > --- a/drivers/hwmon/ntc_thermistor.c > +++ b/drivers/hwmon/ntc_thermistor.c > @@ -430,7 +430,7 @@ static int ntc_thermistor_get_ohm(struct ntc_data *da= ta) > return -EINVAL; > } > =20 > -static int ntc_read_temp(void *dev, long *temp) > +static int ntc_read_temp(void *dev, unsigned long *temp) > { > struct ntc_data *data =3D dev_get_drvdata(dev); > int ohm; > diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c > index 9da2735..25bd72b 100644 > --- a/drivers/hwmon/tmp102.c > +++ b/drivers/hwmon/tmp102.c > @@ -98,7 +98,7 @@ static struct tmp102 *tmp102_update_device(struct devic= e *dev) > return tmp102; > } > =20 > -static int tmp102_read_temp(void *dev, long *temp) > +static int tmp102_read_temp(void *dev, unsigned long *temp) > { > struct tmp102 *tmp102 =3D tmp102_update_device(dev); > =20 > diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchsc= reen/sun4i-ts.c > index b93a28b..26a7cf5 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -198,7 +198,7 @@ static int sun4i_get_temp(const struct sun4i_ts_data = *ts, long *temp) > return 0; > } > =20 > -static int sun4i_get_tz_temp(void *data, long *temp) > +static int sun4i_get_tz_temp(void *data, unsigned long *temp) > { > return sun4i_get_temp(data, temp); > } > diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchi= p_thermal.c > index 3aa46ac..67dfc67 100644 > --- a/drivers/thermal/rockchip_thermal.c > +++ b/drivers/thermal/rockchip_thermal.c > @@ -366,7 +366,7 @@ static irqreturn_t rockchip_thermal_alarm_irq_thread(= int irq, void *dev) > return IRQ_HANDLED; > } > =20 > -static int rockchip_thermal_get_temp(void *_sensor, long *out_temp) > +static int rockchip_thermal_get_temp(void *_sensor, unsigned long *out_t= emp) > { > struct rockchip_thermal_sensor *sensor =3D _sensor; > struct rockchip_thermal_data *thermal =3D sensor->thermal; > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsu= ng/exynos_tmu.c > index 1d30b09..5f721f2 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -713,7 +713,7 @@ static void exynos7_tmu_control(struct platform_devic= e *pdev, bool on) > writel(con, data->base + EXYNOS_TMU_REG_CONTROL); > } > =20 > -static int exynos_get_temp(void *p, long *temp) > +static int exynos_get_temp(void *p, unsigned long *temp) > { > struct exynos_tmu_data *data =3D p; > =20 > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soc= therm.c > index 9197fc0..1c4e455 100644 > --- a/drivers/thermal/tegra_soctherm.c > +++ b/drivers/thermal/tegra_soctherm.c > @@ -306,7 +306,7 @@ static long translate_temp(u16 val) > return t; > } > =20 > -static int tegra_thermctl_get_temp(void *data, long *out_temp) > +static int tegra_thermctl_get_temp(void *data, unsigned long *out_temp) > { > struct tegra_thermctl_zone *zone =3D data; > u32 val; > diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers= /thermal/ti-soc-thermal/ti-thermal-common.c > index 7f8e5f3..f480a01 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > @@ -76,7 +76,7 @@ static inline int ti_thermal_hotspot_temperature(int t,= int s, int c) > =20 > /* thermal zone ops */ > /* Get temperature callback function for thermal zone*/ > -static inline int __ti_thermal_get_temp(void *devdata, long *temp) > +static inline int __ti_thermal_get_temp(void *devdata, unsigned long *te= mp) > { > struct thermal_zone_device *pcb_tz =3D NULL; > struct ti_thermal_data *data =3D devdata; > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index ba2e29a..2f77091 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -272,7 +272,7 @@ struct thermal_genl_event { > * temperature. > */ > struct thermal_zone_of_device_ops { > - int (*get_temp)(void *, long *); > + int (*get_temp)(void *, unsigned long *); > int (*get_trend)(void *, int trend, enum thermal_trend *); > int (*set_emul_temp)(void *, unsigned long); > }; > --=20 > 2.1.4 >=20 --924gEkU1VlJlwnwX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBAgAGBQJVI0CgAAoJEMLUO4d9pOJWA2kH/2ovnchNCUKUuaORqxU3eZb6 vnult/gVTYA6qTJ09uCwgGzVN1M6zyoouLg7eky3c5NfOxfyQ/uASXoVyAdT7J5w WEvgK4CcsdoxJWNt5FbUYnCGS3RXs5uuxIFPumEga7qfCXyAirPgTzAbH4tsBvHT JXEjG1AazPy/RY9nT4pwqWiyO6dRcAf9AEZM7CkSO4K+V2C2DIizLfMy2DNTu9Ly i0sycW0iW1tK1txzDcHBt5aTdyo+JX3piPs8MyLWR67RJRHuCLDuwUxZYXq6IcdN DgG01u1QDBVuRRpoX8HkGorwkqX9DecYk0+g3Nvoptz9yGFPo8BdrKanbxG782k= =zCbU -----END PGP SIGNATURE----- --924gEkU1VlJlwnwX-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: edubezval@gmail.com (Eduardo Valentin) Date: Mon, 6 Apr 2015 19:27:52 -0700 Subject: [PATCH 07/13] thermal: of: streamline .get_temp callbacks In-Reply-To: <1427385240-6086-8-git-send-email-s.hauer@pengutronix.de> References: <1427385240-6086-1-git-send-email-s.hauer@pengutronix.de> <1427385240-6086-8-git-send-email-s.hauer@pengutronix.de> Message-ID: <20150407022750.GF4648@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 26, 2015 at 04:53:54PM +0100, Sascha Hauer wrote: > In the thermal framework it was decided that temperatures can't > be negative, so let the .get_temp callback in struct > thermal_zone_of_device_ops take an unsigned long pointer for > the temperature like the .get_temp callback in > struct thermal_zone_device_ops does. This change is required. However, better we move to the direction of using signed type for temperature. However, we want to have int instead of long though. > > Signed-off-by: Sascha Hauer > --- > drivers/hwmon/lm75.c | 2 +- > drivers/hwmon/ntc_thermistor.c | 2 +- > drivers/hwmon/tmp102.c | 2 +- > drivers/input/touchscreen/sun4i-ts.c | 2 +- > drivers/thermal/rockchip_thermal.c | 2 +- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > drivers/thermal/tegra_soctherm.c | 2 +- > drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 2 +- > include/linux/thermal.h | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index fe41d5a..9df3ca3 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -104,7 +104,7 @@ static inline long lm75_reg_to_mc(s16 temp, u8 resolution) > > /* sysfs attributes for hwmon */ > > -static int lm75_read_temp(void *dev, long *temp) > +static int lm75_read_temp(void *dev, unsigned long *temp) > { > struct lm75_data *data = lm75_update_device(dev); > > diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c > index 112e4d4..12cb333 100644 > --- a/drivers/hwmon/ntc_thermistor.c > +++ b/drivers/hwmon/ntc_thermistor.c > @@ -430,7 +430,7 @@ static int ntc_thermistor_get_ohm(struct ntc_data *data) > return -EINVAL; > } > > -static int ntc_read_temp(void *dev, long *temp) > +static int ntc_read_temp(void *dev, unsigned long *temp) > { > struct ntc_data *data = dev_get_drvdata(dev); > int ohm; > diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c > index 9da2735..25bd72b 100644 > --- a/drivers/hwmon/tmp102.c > +++ b/drivers/hwmon/tmp102.c > @@ -98,7 +98,7 @@ static struct tmp102 *tmp102_update_device(struct device *dev) > return tmp102; > } > > -static int tmp102_read_temp(void *dev, long *temp) > +static int tmp102_read_temp(void *dev, unsigned long *temp) > { > struct tmp102 *tmp102 = tmp102_update_device(dev); > > diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c > index b93a28b..26a7cf5 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -198,7 +198,7 @@ static int sun4i_get_temp(const struct sun4i_ts_data *ts, long *temp) > return 0; > } > > -static int sun4i_get_tz_temp(void *data, long *temp) > +static int sun4i_get_tz_temp(void *data, unsigned long *temp) > { > return sun4i_get_temp(data, temp); > } > diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c > index 3aa46ac..67dfc67 100644 > --- a/drivers/thermal/rockchip_thermal.c > +++ b/drivers/thermal/rockchip_thermal.c > @@ -366,7 +366,7 @@ static irqreturn_t rockchip_thermal_alarm_irq_thread(int irq, void *dev) > return IRQ_HANDLED; > } > > -static int rockchip_thermal_get_temp(void *_sensor, long *out_temp) > +static int rockchip_thermal_get_temp(void *_sensor, unsigned long *out_temp) > { > struct rockchip_thermal_sensor *sensor = _sensor; > struct rockchip_thermal_data *thermal = sensor->thermal; > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 1d30b09..5f721f2 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -713,7 +713,7 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on) > writel(con, data->base + EXYNOS_TMU_REG_CONTROL); > } > > -static int exynos_get_temp(void *p, long *temp) > +static int exynos_get_temp(void *p, unsigned long *temp) > { > struct exynos_tmu_data *data = p; > > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c > index 9197fc0..1c4e455 100644 > --- a/drivers/thermal/tegra_soctherm.c > +++ b/drivers/thermal/tegra_soctherm.c > @@ -306,7 +306,7 @@ static long translate_temp(u16 val) > return t; > } > > -static int tegra_thermctl_get_temp(void *data, long *out_temp) > +static int tegra_thermctl_get_temp(void *data, unsigned long *out_temp) > { > struct tegra_thermctl_zone *zone = data; > u32 val; > diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > index 7f8e5f3..f480a01 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > @@ -76,7 +76,7 @@ static inline int ti_thermal_hotspot_temperature(int t, int s, int c) > > /* thermal zone ops */ > /* Get temperature callback function for thermal zone*/ > -static inline int __ti_thermal_get_temp(void *devdata, long *temp) > +static inline int __ti_thermal_get_temp(void *devdata, unsigned long *temp) > { > struct thermal_zone_device *pcb_tz = NULL; > struct ti_thermal_data *data = devdata; > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index ba2e29a..2f77091 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -272,7 +272,7 @@ struct thermal_genl_event { > * temperature. > */ > struct thermal_zone_of_device_ops { > - int (*get_temp)(void *, long *); > + int (*get_temp)(void *, unsigned long *); > int (*get_trend)(void *, int trend, enum thermal_trend *); > int (*set_emul_temp)(void *, unsigned long); > }; > -- > 2.1.4 > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: