All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Pin tiled objects for L-shaped configs
Date: Tue, 7 Apr 2015 11:43:50 +0100	[thread overview]
Message-ID: <20150407104350.GA14488@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20150407080539.GM6354@phenom.ffwll.local>

On Tue, Apr 07, 2015 at 10:05:39AM +0200, Daniel Vetter wrote:
> On Fri, Apr 03, 2015 at 10:43:29AM +0100, Chris Wilson wrote:
> > I resurrected my dual-channel evenly loaded gm45 and to my surprise
> > found it reporting a L-shaped memory layout.
> 
> Well my gm45 is also dual-channel and evenly loaded and still mangles
> tiled buffers when going through swap. Is gem_tiled_swapping happy on your
> box?

ickle@x200s ~/intel-gpu-tools/tests $ sudo ./gem_tiled_swapping 
IGT-Version: 1.10-ge809895 (x86_64) (Linux: 4.0.0-rc6+ x86_64)
Using 640 1MiB objects (available RAM: 343/3847, swap: 3989)
Subtest non-threaded: SUCCESS (23.344s)
Subtest threaded: SUCCESS (110.801s)

> > Perhaps the if ((ddc2 & DISABLE) == 0) is inverted or is not the truly
> > magic bit?
> 
> It was the best one I could find - given how old this all is now I think
> some false positives are acceptable in the test. I did try a few other
> things which did all fail.

It's the false-negative I worry about. I am just worried this is not the
bit we are looking for. Time will tell if we get a new bug report with
broken swizzling after swapping.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2015-04-07 10:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 13:41 [PATCH] drm/i915: Pin tiled objects for L-shaped configs Daniel Vetter
2014-11-18 14:01 ` Chris Wilson
2014-11-18 14:37   ` Daniel Vetter
2014-11-20  8:26 ` Daniel Vetter
2014-11-20  8:37   ` Chris Wilson
2014-11-20  9:22     ` Daniel Vetter
2014-11-20  9:32       ` Chris Wilson
2015-04-03  9:43   ` Chris Wilson
2015-04-07  8:05     ` Daniel Vetter
2015-04-07 10:43       ` Chris Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407104350.GA14488@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.