All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Baozi <cbz@baozis.org>
To: Julien Grall <julien.grall@citrix.com>
Cc: julien.grall@linaro.org, ian.campbell@citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm64: Use virtual address when setting up early_printk fixmap
Date: Tue, 7 Apr 2015 19:18:54 +0800	[thread overview]
Message-ID: <20150407111854.GB16545@cbz-thinkpad> (raw)
In-Reply-To: <5523BA70.1040701@citrix.com>

On Tue, Apr 07, 2015 at 12:07:28PM +0100, Julien Grall wrote:
> Hi Chen,
> 
> On 07/04/2015 08:33, Chen Baozi wrote:
> >From: Chen Baozi <baozich@gmail.com>
> >
> >We have already had the boot pagetable when reaching the point
> >of early_printk fixmap setup. Thus there is no longer necessary
> >to caculate physical address of xen_fixmap.
> 
> s/caculate/calculate/
> 

Oops, ;-)

> 
> OOI, is it a bug or a clean up?

I think it should be a clean up. There is 1:1 mapping at early stage.
So it is all right to access the 'physical' address.

> 
> >
> >Signed-off-by: Chen Baozi <baozich@gmail.com>
> >---
> >  xen/arch/arm/arm64/head.S | 1 -
> >  1 file changed, 1 deletion(-)
> >
> >diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> >index 75b7ee1..a2ac2d4 100644
> >--- a/xen/arch/arm/arm64/head.S
> >+++ b/xen/arch/arm/arm64/head.S
> >@@ -520,7 +520,6 @@ paging:
> >
> >          /* Add UART to the fixmap table */
> >          ldr   x1, =xen_fixmap
> >-        add   x1, x1, x20            /* x1 := paddr (xen_fixmap) */
> 
> You need to add a comment on "ldr x1..." in order to explain what x1
> contains. i.e /* x1 := vaddr (xen_fixmap) */

Ok. I'll add it in V2.

Cheers,

Baozi.

      reply	other threads:[~2015-04-07 11:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  7:33 [PATCH] xen/arm64: Use virtual address when setting up early_printk fixmap Chen Baozi
2015-04-07 11:07 ` Julien Grall
2015-04-07 11:18   ` Chen Baozi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407111854.GB16545@cbz-thinkpad \
    --to=cbz@baozis.org \
    --cc=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.