From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754283AbbDGOjJ (ORCPT ); Tue, 7 Apr 2015 10:39:09 -0400 Received: from casper.infradead.org ([85.118.1.10]:39934 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbbDGOjH (ORCPT ); Tue, 7 Apr 2015 10:39:07 -0400 Date: Tue, 7 Apr 2015 16:38:55 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: Joe Perches , Juri Lelli , Borislav Petkov , Ingo Molnar , LKML , Juri Lelli Subject: Re: [PATCH] sched/core: Drop debugging leftover trace_printk call Message-ID: <20150407143855.GO23123@twins.programming.kicks-ass.net> References: <1428050570-21041-1-git-send-email-bp@alien8.de> <5523E006.4050507@arm.com> <1428415297.20888.92.camel@perches.com> <20150407101036.59f1427e@gandalf.local.home> <1428416773.20888.100.camel@perches.com> <20150407103404.49028491@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150407103404.49028491@gandalf.local.home> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 10:34:04AM -0400, Steven Rostedt wrote: > I still rather have this be an ERROR and not a WARN, because I rather > avoid even those that encapsulate it with CONFIG_FOO_DEBUG. Lets look at it this way; Steve maintains that trace_printk() thing, if he says its an ERROR, it is.