From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 03/17] IB/Verbs: Use management helper cap_ib_mad() for mad-check Date: Tue, 7 Apr 2015 11:26:12 -0600 Message-ID: <20150407172612.GA15704@obsidianresearch.com> References: <5523CCD5.6030401@profitbricks.com> <5523CDDE.4050209@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5523CDDE.4050209-EIkl63zCoXaH+58JC4qpiA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Wang Cc: Roland Dreier , Sean Hefty , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hal Rosenstock , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Upinder Malhi , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , Ira Weiny , PJ Waskiewicz , Tatyana Nikolova , Or Gerlitz , Jack Morgenstein , Haggai List-Id: linux-rdma@vger.kernel.org On Tue, Apr 07, 2015 at 02:30:22PM +0200, Michael Wang wrote: > - if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB) > - return; > - > if (device->node_type == RDMA_NODE_IB_SWITCH) { > start = 0; > end = 0; > @@ -3069,6 +3066,9 @@ static void ib_mad_init_device(struct ib_device *device) > } > > for (i = start; i <= end; i++) { > + if (!cap_ib_mad(device, i)) > + continue; > + I would prefer to see these changes in control flow as dedicated patches, at the top of your patch stack. For this kind of work a patch should be mechanical changes only, it is easier to review that way. Same comment applies throughout. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbbDGR0e (ORCPT ); Tue, 7 Apr 2015 13:26:34 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:49082 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012AbbDGR0b (ORCPT ); Tue, 7 Apr 2015 13:26:31 -0400 Date: Tue, 7 Apr 2015 11:26:12 -0600 From: Jason Gunthorpe To: Michael Wang Cc: Roland Dreier , Sean Hefty , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Hal Rosenstock , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Upinder Malhi , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , Ira Weiny , PJ Waskiewicz , Tatyana Nikolova , Or Gerlitz , Jack Morgenstein , Haggai Eran , Ilya Nelkenbaum , Yann Droneaud , Bart Van Assche , Shachar Raindel , Sagi Grimberg , Devesh Sharma , Matan Barak , Moni Shoua , Jiri Kosina , Selvin Xavier , Mitesh Ahuja , Li RongQing , Rasmus Villemoes , Alex Estrin , Doug Ledford , Eric Dumazet , Erez Shitrit , Tom Gundersen , Chuck Lever Subject: Re: [PATCH v2 03/17] IB/Verbs: Use management helper cap_ib_mad() for mad-check Message-ID: <20150407172612.GA15704@obsidianresearch.com> References: <5523CCD5.6030401@profitbricks.com> <5523CDDE.4050209@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5523CDDE.4050209@profitbricks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 02:30:22PM +0200, Michael Wang wrote: > - if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB) > - return; > - > if (device->node_type == RDMA_NODE_IB_SWITCH) { > start = 0; > end = 0; > @@ -3069,6 +3066,9 @@ static void ib_mad_init_device(struct ib_device *device) > } > > for (i = start; i <= end; i++) { > + if (!cap_ib_mad(device, i)) > + continue; > + I would prefer to see these changes in control flow as dedicated patches, at the top of your patch stack. For this kind of work a patch should be mechanical changes only, it is easier to review that way. Same comment applies throughout. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 03/17] IB/Verbs: Use management helper cap_ib_mad() for mad-check Date: Tue, 7 Apr 2015 11:26:12 -0600 Message-ID: <20150407172612.GA15704@obsidianresearch.com> References: <5523CCD5.6030401@profitbricks.com> <5523CDDE.4050209@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Roland Dreier , Sean Hefty , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hal Rosenstock , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Upinder Malhi , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , Ira Weiny , PJ Waskiewicz , Tatyana Nikolova , Or Gerlitz , Jack Morgenstein , Haggai Er To: Michael Wang Return-path: Content-Disposition: inline In-Reply-To: <5523CDDE.4050209-EIkl63zCoXaH+58JC4qpiA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Tue, Apr 07, 2015 at 02:30:22PM +0200, Michael Wang wrote: > - if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB) > - return; > - > if (device->node_type == RDMA_NODE_IB_SWITCH) { > start = 0; > end = 0; > @@ -3069,6 +3066,9 @@ static void ib_mad_init_device(struct ib_device *device) > } > > for (i = start; i <= end; i++) { > + if (!cap_ib_mad(device, i)) > + continue; > + I would prefer to see these changes in control flow as dedicated patches, at the top of your patch stack. For this kind of work a patch should be mechanical changes only, it is easier to review that way. Same comment applies throughout. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html