From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/2] perf, record: Add clockid parameter
Date: Tue, 7 Apr 2015 19:33:37 +0200 [thread overview]
Message-ID: <20150407173337.GB22603@krava.redhat.com> (raw)
In-Reply-To: <20150407154851.GR23123@twins.programming.kicks-ass.net>
On Tue, Apr 07, 2015 at 05:48:51PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 07, 2015 at 11:09:53AM +0200, Peter Zijlstra wrote:
> > @@ -739,6 +813,7 @@ static struct record record = {
> > .uses_mmap = true,
> > .default_per_cpu = true,
> > },
> > + .clockid = -1,
> > },
>
> As spotted by dahern this is not working well for all other record_opts
> instances, fix that by adding a use_clockid field just like
> perf_event_attr has.
hum, havent realized that.. I saw Arnaldo already included
this one in pull req., anyway FWIW it looks ok ;-)
jirka
next prev parent reply other threads:[~2015-04-07 17:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 9:09 [PATCH 0/2] perf tools: clock_id support and perf_event_attr printing Peter Zijlstra
2015-04-07 9:09 ` [PATCH 1/2] perf, record: Add clockid parameter Peter Zijlstra
2015-04-07 15:48 ` Peter Zijlstra
2015-04-07 17:33 ` Jiri Olsa [this message]
2015-04-08 9:47 ` Peter Zijlstra
2015-04-08 15:14 ` [tip:perf/core] perf " tip-bot for Peter Zijlstra
2015-04-07 9:09 ` [PATCH 2/2] perf, tools: Merge all perf_event_attr print functions Peter Zijlstra
2015-04-07 13:32 ` Arnaldo Carvalho de Melo
2015-04-08 15:14 ` [tip:perf/core] perf " tip-bot for Peter Zijlstra
2015-04-07 9:23 ` [PATCH 0/2] perf tools: clock_id support and perf_event_attr printing Ingo Molnar
2015-04-07 12:08 ` Arnaldo Carvalho de Melo
2015-04-07 12:25 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407173337.GB22603@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.