From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756211AbbDGPzO (ORCPT ); Tue, 7 Apr 2015 11:55:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54669 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753600AbbDGPzL (ORCPT ); Tue, 7 Apr 2015 11:55:11 -0400 Date: Tue, 7 Apr 2015 17:55:08 +0200 From: "Michael S. Tsirkin" To: Greg Kurz Cc: Rusty Russell , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 0/7] vhost: support for cross endian guests Message-ID: <20150407175443-mutt-send-email-mst@redhat.com> References: <20150407120929.4213.8225.stgit@bahia.lab.toulouse-stg.fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150407120929.4213.8225.stgit@bahia.lab.toulouse-stg.fr.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 02:09:29PM +0200, Greg Kurz wrote: > Hi, > > This patchset allows vhost to be used with legacy virtio when guest and host > have a different endianness. > > Patches 1-6 remain the same as the previous post. Patch 7 was heavily changed > according to MST's comments. This still doesn't actually work, right? tun and macvtap need new ioctls too ... > --- > > Greg Kurz (7): > virtio: introduce virtio_is_little_endian() helper > tun: add tun_is_little_endian() helper > macvtap: introduce macvtap_is_little_endian() helper > vringh: introduce vringh_is_little_endian() helper > vhost: introduce vhost_is_little_endian() helper > virtio: add explicit big-endian support to memory accessors > vhost: feature to set the vring endianness > > > drivers/net/macvtap.c | 11 ++++++-- > drivers/net/tun.c | 11 ++++++-- > drivers/vhost/Kconfig | 10 +++++++ > drivers/vhost/vhost.c | 55 ++++++++++++++++++++++++++++++++++++++ > drivers/vhost/vhost.h | 34 +++++++++++++++++++---- > include/linux/virtio_byteorder.h | 24 ++++++++++------- > include/linux/virtio_config.h | 19 +++++++++---- > include/linux/vringh.h | 19 +++++++++---- > include/uapi/linux/vhost.h | 5 +++ > 9 files changed, 156 insertions(+), 32 deletions(-) > > -- > Greg From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v3 0/7] vhost: support for cross endian guests Date: Tue, 7 Apr 2015 17:55:08 +0200 Message-ID: <20150407175443-mutt-send-email-mst@redhat.com> References: <20150407120929.4213.8225.stgit@bahia.lab.toulouse-stg.fr.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150407120929.4213.8225.stgit-to6p26YowclJmDnNpxttO7KMsZMIf1jtdfLczzV0R5oAvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kurz Cc: Rusty Russell , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-api@vger.kernel.org On Tue, Apr 07, 2015 at 02:09:29PM +0200, Greg Kurz wrote: > Hi, > > This patchset allows vhost to be used with legacy virtio when guest and host > have a different endianness. > > Patches 1-6 remain the same as the previous post. Patch 7 was heavily changed > according to MST's comments. This still doesn't actually work, right? tun and macvtap need new ioctls too ... > --- > > Greg Kurz (7): > virtio: introduce virtio_is_little_endian() helper > tun: add tun_is_little_endian() helper > macvtap: introduce macvtap_is_little_endian() helper > vringh: introduce vringh_is_little_endian() helper > vhost: introduce vhost_is_little_endian() helper > virtio: add explicit big-endian support to memory accessors > vhost: feature to set the vring endianness > > > drivers/net/macvtap.c | 11 ++++++-- > drivers/net/tun.c | 11 ++++++-- > drivers/vhost/Kconfig | 10 +++++++ > drivers/vhost/vhost.c | 55 ++++++++++++++++++++++++++++++++++++++ > drivers/vhost/vhost.h | 34 +++++++++++++++++++---- > include/linux/virtio_byteorder.h | 24 ++++++++++------- > include/linux/virtio_config.h | 19 +++++++++---- > include/linux/vringh.h | 19 +++++++++---- > include/uapi/linux/vhost.h | 5 +++ > 9 files changed, 156 insertions(+), 32 deletions(-) > > -- > Greg