From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbbDGR5U (ORCPT ); Tue, 7 Apr 2015 13:57:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41738 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbbDGR5S (ORCPT ); Tue, 7 Apr 2015 13:57:18 -0400 Date: Tue, 7 Apr 2015 19:57:09 +0200 From: Jiri Olsa To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, namhyung@kernel.org Subject: Re: [PATCH 1/2] perf tools: Add 'perf-config' command Message-ID: <20150407175709.GA25980@krava.redhat.com> References: <1428169288-8482-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428169288-8482-1-git-send-email-treeze.taeung@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 05, 2015 at 02:41:27AM +0900, Taeung Song wrote: SNIP > + "perf config [options]", > + NULL > +}; > +static const struct option config_options[] = { > + OPT_BOOLEAN('l', "list", ¶ms.list_action, "list up current configurations"), > + OPT_END() > +}; > + > +static void check_argc(int argc, int min, int max) seems like all callers have min == max, so there's no need for 2 params jirka