From: Peter Zijlstra <peterz@infradead.org>
To: Chris Metcalf <cmetcalf@ezchip.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus
Date: Wed, 8 Apr 2015 19:27:46 +0200 [thread overview]
Message-ID: <20150408172746.GK5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <55254794.4070503@ezchip.com>
On Wed, Apr 08, 2015 at 11:21:56AM -0400, Chris Metcalf wrote:
> Apparently the body of the commit message isn't as clear as it might be :-)
>
> It does say the same thing, though, basically that if nohz_full DOESN'T
> imply isolcpus, that's a bad thing. I'm happy to reword the text to avoid
> the double negative and say:
>
> nohz_full is only useful with isolcpus also set, since otherwise the
> scheduler has to run periodically to try to determine whether to steal
> work from other cores.
But you're doing the reverse! You're setting nohz_full for isolcpus, not
limiting the nohz_full mask to isolcpus.
next prev parent reply other threads:[~2015-04-08 17:27 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 16:24 [PATCH 1/2] nohz: add tick_nohz_full_set_cpus() API cmetcalf
2015-04-03 16:24 ` [PATCH 2/2] nohz: make nohz_full imply isolcpus cmetcalf
2015-04-03 17:42 ` Frederic Weisbecker
2015-04-03 19:20 ` Chris Metcalf
2015-04-04 14:10 ` Rik van Riel
2015-04-04 17:09 ` Chris Metcalf
2015-04-05 5:05 ` Ingo Molnar
2015-04-06 17:15 ` Chris Metcalf
2015-04-06 18:16 ` [PATCH v2 1/2] nohz: add tick_nohz_full_clear_cpus() and _set_cpus() APIs cmetcalf
2015-04-06 18:16 ` [PATCH v2 2/2] nohz: make nohz_full imply isolcpus cmetcalf
2015-04-07 22:29 ` Frederic Weisbecker
2015-04-08 9:41 ` Peter Zijlstra
2015-04-08 14:04 ` Chris Metcalf
2015-04-08 14:26 ` Peter Zijlstra
2015-04-08 15:21 ` Chris Metcalf
2015-04-08 17:24 ` Frederic Weisbecker
2015-04-08 19:20 ` [PATCH v3 1/2] nohz: add tick_nohz_full_clear_cpus() and _set_cpus() APIs cmetcalf
2015-04-08 19:20 ` [PATCH v3 2/2] nohz: set isolcpus when nohz_full is set cmetcalf
2015-04-08 17:27 ` Peter Zijlstra [this message]
2015-04-08 18:12 ` [PATCH v2 2/2] nohz: make nohz_full imply isolcpus Chris Metcalf
2015-04-09 8:29 ` Peter Zijlstra
2015-04-09 12:02 ` Chris Metcalf
2015-04-09 12:45 ` Frederic Weisbecker
2015-04-09 16:59 ` [PATCH v5] nohz: set isolcpus when nohz_full is set Chris Metcalf
2015-04-09 17:12 ` Peter Zijlstra
2015-04-10 1:05 ` Mike Galbraith
2015-04-10 15:33 ` Chris Metcalf
2015-04-10 15:57 ` Mike Galbraith
2015-04-09 17:00 ` [PATCH v4 1/2] nohz: add tick_nohz_full_cpumask_or() and _andnot() APIs Chris Metcalf
2015-04-09 17:00 ` [PATCH v4 2/2] nohz: set isolcpus when nohz_full is set Chris Metcalf
2015-04-09 17:07 ` [PATCH v4 1/2] nohz: add tick_nohz_full_cpumask_or() and _andnot() APIs Peter Zijlstra
2015-04-09 17:24 ` Chris Metcalf
2015-04-09 17:42 ` Peter Zijlstra
2015-04-09 18:01 ` [PATCH v6 1/2] nohz: add tick_nohz_full_add_cpus_to() and _remove_cpus_from() APIs Chris Metcalf
2015-04-09 18:01 ` [PATCH v6 2/2] nohz: set isolcpus when nohz_full is set Chris Metcalf
2015-04-10 1:37 ` Frederic Weisbecker
2015-04-10 20:53 ` [PATCH v7 1/2] nohz: add tick_nohz_full_add_cpus_to() and _remove_cpus_from() APIs Chris Metcalf
2015-04-10 20:53 ` [PATCH v7 2/2] nohz: set isolcpus when nohz_full is set Chris Metcalf
2015-04-14 0:37 ` Frederic Weisbecker
2015-04-14 15:17 ` [PATCH v8 1/2] nohz: add tick_nohz_full_add_cpus_to() API Chris Metcalf
2015-04-14 15:17 ` [PATCH v8 2/2] nohz: set isolcpus when nohz_full is set Chris Metcalf
2015-04-14 15:26 ` Frederic Weisbecker
2015-04-14 16:45 ` Peter Zijlstra
2015-04-14 0:33 ` [PATCH v7 1/2] nohz: add tick_nohz_full_add_cpus_to() and _remove_cpus_from() APIs Frederic Weisbecker
2015-04-14 0:49 ` Chris Metcalf
2015-04-14 15:34 ` Frederic Weisbecker
2015-04-10 1:34 ` [PATCH v6 " Frederic Weisbecker
2015-04-10 15:31 ` Chris Metcalf
2015-04-06 18:29 ` [PATCH v2 1/2] nohz: add tick_nohz_full_clear_cpus() and _set_cpus() APIs Frederic Weisbecker
2015-04-06 19:09 ` Chris Metcalf
2015-04-07 9:33 ` Ingo Molnar
2015-04-03 18:08 ` [PATCH 2/2] nohz: make nohz_full imply isolcpus Mike Galbraith
2015-04-03 19:21 ` Chris Metcalf
2015-04-04 2:03 ` Mike Galbraith
2015-04-04 3:43 ` Mike Galbraith
2015-04-06 19:28 ` Rik van Riel
2015-04-07 3:10 ` Mike Galbraith
2015-05-06 16:04 [GIT PULL] nohz: A few improvements v4 Frederic Weisbecker
2015-05-06 16:04 ` [PATCH 1/4] context_tracking: Protect against recursion Frederic Weisbecker
2015-05-07 9:58 ` Ingo Molnar
2015-05-07 11:53 ` Frederic Weisbecker
2015-05-07 11:31 ` [tip:timers/nohz] " tip-bot for Frederic Weisbecker
2015-05-06 16:04 ` [PATCH 2/4] context_tracking: Inherit TIF_NOHZ through forks instead of context switches Frederic Weisbecker
2015-05-07 11:31 ` [tip:timers/nohz] " tip-bot for Frederic Weisbecker
2015-05-06 16:04 ` [PATCH 3/4] nohz: Add tick_nohz_full_add_cpus_to() API Frederic Weisbecker
2015-05-07 11:31 ` [tip:timers/nohz] " tip-bot for Chris Metcalf
2015-05-06 16:04 ` [PATCH 4/4] nohz: Set isolcpus when nohz_full is set Frederic Weisbecker
2015-05-07 11:32 ` [tip:timers/nohz] " tip-bot for Chris Metcalf
2015-05-16 19:39 ` [PATCH 4/4] " Sasha Levin
2015-05-17 5:30 ` Mike Galbraith
2015-05-18 2:17 ` Rik van Riel
2015-05-18 3:29 ` Mike Galbraith
2015-05-18 14:07 ` Rik van Riel
2015-05-18 14:22 ` Mike Galbraith
2015-05-18 14:52 ` Rik van Riel
2015-05-19 2:30 ` Mike Galbraith
2015-06-12 19:12 ` Rik van Riel
2015-05-20 20:38 ` Afzal Mohammed
2015-05-20 21:00 ` Paul E. McKenney
2015-05-21 12:12 ` Afzal Mohammed
2015-05-21 12:57 ` Paul E. McKenney
2015-05-21 13:06 ` Frederic Weisbecker
2015-05-21 13:27 ` Paul E. McKenney
2015-05-21 13:29 ` Afzal Mohammed
2015-05-21 14:14 ` Paul E. McKenney
2015-05-21 14:46 ` Frederic Weisbecker
2015-05-21 18:59 ` Mike Galbraith
2015-05-22 14:39 ` Frederic Weisbecker
2015-05-22 15:20 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408172746.GK5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=cmetcalf@ezchip.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.