From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH 05/10] VMX: add help functions to support PML
Date: Thu, 9 Apr 2015 13:31:38 +0100
Message-ID: <20150409123138.GJ17031@deinos.phlegethon.org>
References: <1427423754-11841-1-git-send-email-kai.huang@linux.intel.com>
	<1427423754-11841-6-git-send-email-kai.huang@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1427423754-11841-6-git-send-email-kai.huang@linux.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Kai Huang <kai.huang@linux.intel.com>
Cc: yang.z.zhang@intel.com, andrew.cooper3@citrix.com, kevin.tian@intel.com, jbeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

At 10:35 +0800 on 27 Mar (1427452549), Kai Huang wrote:
> +void vmx_vcpu_disable_pml(struct vcpu *v)
> +{
> +    ASSERT(vmx_vcpu_pml_enabled(v));
> +

I think this function ought to call vmx_vcpu_flush_pml_buffer() before
disabling PML.  That way we don't need to worry about losing any
information if a guest vcpu is reset or offlined during migration. 

Cheers,

Tim.