From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 1/4] drm/i915: Make atomic use in-flight state for CRTC active value Date: Thu, 9 Apr 2015 07:10:57 -0700 Message-ID: <20150409141057.GL11603@intel.com> References: <1428544614-28082-1-git-send-email-matthew.d.roper@intel.com> <1428544614-28082-2-git-send-email-matthew.d.roper@intel.com> <20150409131856.GT17410@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 52ED06E7A6 for ; Thu, 9 Apr 2015 07:10:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150409131856.GT17410@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDksIDIwMTUgYXQgMDQ6MTg6NTZQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgQXByIDA4LCAyMDE1IGF0IDA2OjU2OjUxUE0gLTA3MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBPdXIgYXRvbWljIHBsYW5lIGNvZGUgY3VycmVudGx5IHVzZXMgaW50 ZWxfY3J0Yy0+YWN0aXZlIHRvIGRldGVybWluZQo+ID4gaG93L3doZW4gdG8gdXBkYXRlIHNvbWUg ZGVyaXZlZCBzdGF0ZSB2YWx1ZXMuICBUaGlzIHdvcmtzIGZpbmUgZm9yIHB1cmUKPiA+IHBsYW5l IHVwZGF0ZXMgYXQgdGhlIG1vbWVudCBzaW5jZSB0aGUgQ1JUQyBzdGF0ZSBpdHNlbGYgaXNuJ3Qg Y2hhbmdlZCBhcwo+ID4gcGFydCBvZiB0aGUgb3BlcmF0aW9uLiAgSG93ZXZlciBhcyB3ZSBjb252 ZXJ0IG1vcmUgb2Ygb3VyIGRyaXZlcgo+ID4gaW50ZXJuYWxzIG92ZXIgdG8gYXRvbWljIG1vZGVz ZXR0aW5nLCB3ZSBuZWVkIHRvIGxvb2sgYXQgd2hldGhlciB0aGUKPiA+IENSVEMgd2lsbCBiZSBh Y3RpdmUgYXQgdGhlICplbmQqIG9mIHRoZSBhdG9taWMgdHJhbnNhY3Rpb24gKHdoaWNoIG1heQo+ ID4gbm90IG1hdGNoIHRoZSBjdXJyZW50bHkgY29tbWl0dGVkIHN0YXRlKS4KPiA+IAo+ID4gVGhl IGluLWZsaWdodCB2YWx1ZSB3ZSB3YW50IHRvIHVzZSBpcyBnZW5lcmFsbHkgaW4gYSBjcnRjX3N0 YXRlIG9iamVjdAo+ID4gYXNzb2NpYXRlZCB3aXRoIG91ciB0b3AtbGV2ZWwgYXRvbWljIHRyYW5z YWN0aW9uLiAgSG93ZXZlciB0aGVyZSBhcmUgYQo+ID4gZmV3IGNhc2VzIHdoZXJlIHRoaXMgaXNu J3QgdGhlIGNhc2U6Cj4gPiAKPiA+ICAqIFdoaWxlIHVzaW5nIHRyYW5zaXRpb25hbCBhdG9taWMg aGVscGVycyAoYXMgd2UgYXJlIGF0IHRoZSBtb21lbnQpLAo+ID4gICAgU2V0UGxhbmUoKSBjYWxs cyB3aWxsIG9wZXJhdGUgb24gb3JwaGFuZWQgcGxhbmUgc3RhdGVzIHRoYXQgYXJlbid0Cj4gPiAg ICBwYXJ0IG9mIGEgdG9wLWxldmVsIGF0b21pYyB0cmFuc2FjdGlvbi4gIEluIHRoaXMgY2FzZSwg d2UncmUgbm90Cj4gPiAgICB0b3VjaGluZyB0aGUgQ1JUQyBzdGF0ZSwgc28gaXQncyBmaW5lIHRv IHVzZSB0aGUgYWxyZWFkeS1jb21taXR0ZWQKPiA+ICAgIHZhbHVlIGZyb20gY3J0Yy0+c3RhdGUu Cj4gPiAKPiA+ICAqIFdoaWxlIHVwZGF0aW5nIHByb3BlcnRpZXMgb2YgYSBkaXNhYmxlZCBwbGFu ZSwgd2UnbGwgaGF2ZSBhIHRvcC1sZXZlbAo+ID4gICAgYXRvbWljIHN0YXRlLCBidXQgaXQgbWF5 IG5vdCBjb250YWluIHRoZSBDUlRDIHN0YXRlIHdlJ3JlIGxvb2tpbmcKPiA+ICAgIGZvci4gIE9u Y2UgYWdhaW4sIHRoaXMgbWVhbnMgd2UncmUgbm90IGFjdHVhbGx5IHRvdWNoaW5nIGFueSBDUlRD Cj4gPiAgICBzdGF0ZSBzbyBpdCdzIHNhZmUgdG8gdXNlIHRoZSB2YWx1ZSBmcm9tIGNydGMtPnN0 YXRlIGRpcmVjdGx5Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3 LmQucm9wZXJAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXRvbWljX3BsYW5lLmMgfCAxMSArKystLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyAgICAgIHwgNzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICAgICAgIHwgIDMgKysKPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyAgICAgICB8IDE2ICsrKysrLS0K PiA+ICA0IGZpbGVzIGNoYW5nZWQsIDkzIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3Bs YW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ID4gaW5k ZXggOTc2Yjg5MS4uOTBjNGE4MiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9hdG9taWNfcGxhbmUuYwo+ID4gQEAgLTExMSwxMiArMTExLDE3IEBAIHN0YXRpYyBpbnQgaW50 ZWxfcGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gIHsKPiA+ ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0gc3RhdGUtPmNydGM7Cj4gPiAgCXN0cnVjdCBpbnRl bF9jcnRjICppbnRlbF9jcnRjOwo+ID4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqaW50ZWxf Y3J0Y19zdGF0ZTsKPiA+ICAJc3RydWN0IGludGVsX3BsYW5lICppbnRlbF9wbGFuZSA9IHRvX2lu dGVsX3BsYW5lKHBsYW5lKTsKPiA+ICAJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICppbnRlbF9z dGF0ZSA9IHRvX2ludGVsX3BsYW5lX3N0YXRlKHN0YXRlKTsKPiA+ICsJYm9vbCBhY3RpdmU7Cj4g PiAgCj4gPiAgCWNydGMgPSBjcnRjID8gY3J0YyA6IHBsYW5lLT5jcnRjOwo+ID4gIAlpbnRlbF9j cnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiA+ICAKPiA+ICsJaW50ZWxfY3J0Y19zdGF0ZSA9 IGludGVsX2NydGNfc3RhdGVfZm9yX3BsYW5lKGludGVsX3N0YXRlKTsKPiA+ICsJYWN0aXZlID0g aW50ZWxfY3J0Y19zdGF0ZS0+YmFzZS5lbmFibGU7Cj4gPiArCj4gPiAgCS8qCj4gPiAgCSAqIEJv dGggY3J0YyBhbmQgcGxhbmUtPmNydGMgY291bGQgYmUgTlVMTCBpZiB3ZSdyZSB1cGRhdGluZyBh Cj4gPiAgCSAqIHByb3BlcnR5IHdoaWxlIHRoZSBwbGFuZSBpcyBkaXNhYmxlZC4gIFdlIGRvbid0 IGFjdHVhbGx5IGhhdmUKPiA+IEBAIC0xNDMsMTAgKzE0OCw4IEBAIHN0YXRpYyBpbnQgaW50ZWxf cGxhbmVfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ID4gIAkvKiBDbGlw IGFsbCBwbGFuZXMgdG8gQ1JUQyBzaXplLCBvciAweDAgaWYgQ1JUQyBpcyBkaXNhYmxlZCAqLwo+ ID4gIAlpbnRlbF9zdGF0ZS0+Y2xpcC54MSA9IDA7Cj4gPiAgCWludGVsX3N0YXRlLT5jbGlwLnkx ID0gMDsKPiA+IC0JaW50ZWxfc3RhdGUtPmNsaXAueDIgPQo+ID4gLQkJaW50ZWxfY3J0Yy0+YWN0 aXZlID8gaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193IDogMDsKPiA+IC0JaW50ZWxfc3Rh dGUtPmNsaXAueTIgPQo+ID4gLQkJaW50ZWxfY3J0Yy0+YWN0aXZlID8gaW50ZWxfY3J0Yy0+Y29u ZmlnLT5waXBlX3NyY19oIDogMDsKPiA+ICsJaW50ZWxfc3RhdGUtPmNsaXAueDIgPSBhY3RpdmUg PyBpbnRlbF9jcnRjX3N0YXRlLT5waXBlX3NyY193IDogMDsKPiA+ICsJaW50ZWxfc3RhdGUtPmNs aXAueTIgPSBhY3RpdmUgPyBpbnRlbF9jcnRjX3N0YXRlLT5waXBlX3NyY19oIDogMDsKPiAKPiBX ZSBkZXBlbmQgb24gdGhlIGNsaXBwaW5nIHRvIGtlZXAgcGxhbmVzIGZyb20gZ2V0dGluZyBlbmFi bGVkIG9uIGEKPiBkaXNhYmxlZCBwaXBlLiBTbyBJIHRoaW5rIHRoaXMgaXMgZ29pbmcgdG8gYmxv dyB1cC4KClRoYXQgd2FzIHdoeSBJIG1hZGUgdGhlc2UgY2hhbmdlcy4uLnRoZSBpZGVhIGhlcmUg d2FzIHRoYXQgd2Ugc2hvdWxkIGJlCmJhc2luZyB0aGF0IGNsaXBwaW5nIG9uIHdoYXQgdGhlIENS VEMgc3RhdGUgaXMgZ29pbmcgdG8gYmUgd2hlbiB0aGUKcGxhbmUgc3RhdGUgaXMgYWN0dWFsbHkg Y29tbWl0dGVkLCBub3Qgd2hhdCBpdCBoYXBwZW5zIHRvIGJlIG5vdy4gIFNvIGlmCnRoZSBDUlRD IGlzIGdvaW5nIHRvIGJlIGRpc2FibGVkLCB0aGlzIHNob3VsZCBlbnN1cmUgdGhhdCB0aGUgcGxh bmVzIGFyZQpwcm9wZXJseSBjbGlwcGVkIHRvIG9mZiwgZXZlbiBpZiB0aGUgQ1JUQyBoYXBwZW5z IHRvIGJlIHJ1bm5pbmcgYXQgdGhlCm1vbWVudC4gIENvbnZlcnNlbHksIGlmIHRoZSBDUlRDIGlz IG9mZiBhdCB0aGUgbW9tZW50LCBidXQgd2lsbCBiZSBvbiBhdAp0aGUgZW5kIG9mIHRoaXMgdHJh bnNhY3Rpb24sIHdlIHdhbnQgdG8gbWFrZSBzdXJlIHRoYXQgdGhlIHBsYW5lcyBhcmUKbm90IGlt cHJvcGVybHkgY2xpcHBlZCB0byBpbnZpc2libGUsIG90aGVyd2lzZSB0aGV5IHdvbid0IHNob3cg dXAuCgpBbSBJIG92ZXJsb29raW5nIHNvbWV0aGluZz8gIEl0IHNlZW1zIHRoZSBjdXJyZW50ICdh Y3RpdmUnIHZhbHVlIGlzCnVucmVsYXRlZCB0byB3aGF0IHdlIGFjdHVhbGx5IHdhbnQgdG8gYmUg YmFzaW5nIG91ciBwbGFuZSBwcm9ncmFtbWluZyBvbgphbmQganVzdCBoYXBwZW5zIHRvIHdvcmsg YXQgdGhlIG1vbWVudCBzaW5jZSB3ZSBkb24ndCB5ZXQgbGV0ICAtPmFjdGl2ZQpjaGFuZ2Ugb3Zl ciB0aGUgY291cnNlIG9mIGFuIGF0b21pYyB0cmFuc2FjdGlvbiAobWVhbmluZyB0aGUgZmluYWwg c3RhdGUKd2lsbCBhbHdheXMgYmUgdGhlIHNhbWUgYXMgdGhlIGN1cnJlbnQgc3RhdGUpLgoKCk1h dHQKCi0tIApNYXR0IFJvcGVyCkdyYXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZv cm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5 NQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=