From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgTTm-0005rd-7x for qemu-devel@nongnu.org; Fri, 10 Apr 2015 03:35:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgTTi-0001YD-Uv for qemu-devel@nongnu.org; Fri, 10 Apr 2015 03:35:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgTTi-0001Y8-MB for qemu-devel@nongnu.org; Fri, 10 Apr 2015 03:35:50 -0400 Date: Fri, 10 Apr 2015 09:35:16 +0200 From: Igor Mammedov Message-ID: <20150410093516.12ea7709@igors-macbook-pro.local> In-Reply-To: <552766BD.4040209@huawei.com> References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com> <1428055432-12120-7-git-send-email-zhaoshenglong@huawei.com> <87d23d1vfe.fsf@linaro.org> <20150409150351.0e9e00cb@nial.brq.redhat.com> <552766BD.4040209@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 06/20] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, lersek@redhat.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, msalter@redhat.com, pbonzini@redhat.com, Alex =?UTF-8?Q?Benn=C3=A9e?= , christoffer.dall@linaro.org, shannon.zhao@linaro.org On Fri, 10 Apr 2015 13:59:25 +0800 Shannon Zhao wrote: > On 2015/4/9 21:03, Igor Mammedov wrote: > > On Thu, 09 Apr 2015 10:51:33 +0100 > > Alex Benn=C3=A9e wrote: > >=20 > >> >=20 > >> > Shannon Zhao writes: > >> >=20 > >>> > > From: Shannon Zhao > >>> > > > >>> > > DSDT consists of the usual common table header plus a > >>> > > definition block in AML encoding which describes all devices > >>> > > in the platform. > >>> > > > >>> > > After initializing DSDT with header information the namespace > >>> > > is created which is followed by the device encodings. The > >>> > > devices are described using the Resource Template for the > >>> > > 32-Bit Fixed Memory Range and the Extended Interrupt > >>> > > Descriptors. > >>> > > > >>> > > Signed-off-by: Shannon Zhao > >>> > > Signed-off-by: Shannon Zhao > >>> > > --- > >>> > > hw/arm/virt-acpi-build.c | 137 > >>> > > +++++++++++++++++++++++++++++++++++++++++++++++ 1 file > >>> > > changed, 137 insertions(+) > >>> > > > >>> > > diff --git a/hw/arm/virt-acpi-build.c > >>> > > b/hw/arm/virt-acpi-build.c index 388838a..516c1d0 100644 > >>> > > --- a/hw/arm/virt-acpi-build.c > >>> > > +++ b/hw/arm/virt-acpi-build.c > >>> > > @@ -57,6 +57,139 @@ > >>> > > #define ACPI_BUILD_DPRINTF(fmt, ...) > > I wonder if all this DPRINTF crap should be replaced by tracepoints. > > Oo at least it shouldn't be used in new code. > >=20 >=20 > Anything wrong with using DPRINTF? tracepoints could be enabled without rebuilding qemu