From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgTZ5-0007hu-S1 for qemu-devel@nongnu.org; Fri, 10 Apr 2015 03:41:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgTZ2-0003C9-JY for qemu-devel@nongnu.org; Fri, 10 Apr 2015 03:41:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgTZ2-0003C5-Dc for qemu-devel@nongnu.org; Fri, 10 Apr 2015 03:41:20 -0400 Date: Fri, 10 Apr 2015 09:40:52 +0200 From: Igor Mammedov Message-ID: <20150410094052.10b5ccdb@igors-macbook-pro.local> In-Reply-To: <55276940.4090402@huawei.com> References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com> <1428055432-12120-14-git-send-email-zhaoshenglong@huawei.com> <20150409152241.30e70707@nial.brq.redhat.com> <55276940.4090402@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 13/20] hw/acpi/aml-build: Add ToUUID macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, msalter@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On Fri, 10 Apr 2015 14:10:08 +0800 Shannon Zhao wrote: > On 2015/4/9 21:22, Igor Mammedov wrote: > > On Fri, 3 Apr 2015 18:03:45 +0800 > > Shannon Zhao wrote: > > > >> > From: Shannon Zhao > >> > > >> > Add ToUUID macro, this is useful for generating PCIe ACPI table. > >> > > >> > Signed-off-by: Shannon Zhao > >> > Signed-off-by: Shannon Zhao > >> > --- > >> > hw/acpi/aml-build.c | 23 +++++++++++++++++++++++ > >> > include/hw/acpi/aml-build.h | 2 ++ > >> > 2 files changed, 25 insertions(+) > >> > > >> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > >> > index bd1713c..5a94fc9 100644 > >> > --- a/hw/acpi/aml-build.c > >> > +++ b/hw/acpi/aml-build.c > >> > @@ -933,6 +933,29 @@ Aml *aml_qword_memory(AmlDecode dec, > >> > AmlMinFixed min_fixed, addr_trans, len, flags); > >> > } > >> > > >> > +/* > >> > + * ACPI 3.0: 17.5.124 ToUUID (Convert String to UUID Macro) > >> > + * e.g. UUID: E5C937D0-3553-4d7a-9117-EA4D19C3434D > >> > + * call aml_touuid(0xE5C937D0, 0x3553, 0x4d7a, 0x9117, > >> > 0xEA4D19C3434D); > > hmm, ^^^^ that's definitely no string > > > Yes, the args are not string. When I implemented this function I > thought about this. In order to make it simple, I use HEX here. If we > have to use string, I could modify this. I'd prefer stirngs as it's written in spec