From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933018AbbDJKWR (ORCPT ); Fri, 10 Apr 2015 06:22:17 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:57517 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbbDJKWO (ORCPT ); Fri, 10 Apr 2015 06:22:14 -0400 Date: Fri, 10 Apr 2015 12:22:12 +0200 From: Markus Pargmann To: Ingo Flaschberger Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] w1: gpio: Fix problematic platform_data usage Message-ID: <20150410102212.GF11182@pengutronix.de> References: <54F8445B.10805@gmail.com> <1425896338-31928-1-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b8GWCKCLzrXbuNet" Content-Disposition: inline In-Reply-To: <1425896338-31928-1-git-send-email-mpa@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:20:25 up 79 days, 27 min, 98 users, load average: 0.92, 0.71, 0.77 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --b8GWCKCLzrXbuNet Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Mar 09, 2015 at 11:18:58AM +0100, Markus Pargmann wrote: > pdev->dev.platform_data should not be overwritten by a driver. This > patch fixes this issue by not using platform_get_pdata to get pdata. The > DT routine can then simply return a pdata struct with those information. >=20 > Without this patch the platform_data may be freed twice, by devres and > the driver framework. >=20 > Reported-by: Ingo Flaschberger > Cc: > Signed-off-by: Markus Pargmann Did you have time to test this? I would like to send this mainline but a Tested-by of you would be nice. Best Regards, Markus --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --b8GWCKCLzrXbuNet Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVJ6RUAAoJEEpcgKtcEGQQNo8QAJMfiCzJNN6rnt3MInxz21xJ ZzoJ0UlBR8BQfHXwq6hqqdojt3WG/dhwlIMeyZP9icn3Mln1DDzw9kFrKQRetCXY rmT9VfgZMMqaWPjmMXE0+SVj0F07F04EMxmwEts7YHD6ueFBQ0gsljohMJrlqNps HBu7FAZv2aOIjs5BpihoJciLUeos8FJj5IMduE1HUVCMgvY3085b0yPUB3Qap/xL yqCDsd+3+/pfkrNBM5arGEb4XvDWO1/lKpQniQkNS7aPTnjFAvdl+twl6uGNYp1p otC6YoyIONV36yuWKfCw+g8BcIhXN/vLr+Mdt8Qg6/82KNQVkhlkh6ZsNtEHE0lN xgbuHOVjQANzQVUCRBw7rm9KXGB/RTtO1nvXhtOoCC+hoVjh0YCeIbf7XY9XM+Yh tv+KXqBQqWfa7LsAznmHqbX8zKWL2xJIKn2ntwY3p+c6BJXLMAncSp/A9jkEojwW FZHJEvdrWlrw++/DI2LekEq/lWjD29qpuNh94H+dgp31ExLB+/MTdeE+nIAkV3rL Dy2rl9HykqRn0LWRMzCv2Uhe7ehIp6pzV8wntkQ0GyTbld5rCLdH7Q7H6B4oAjTT XVaRSiXYOJ7CVhXqxuYnCvGQSPGxA1X3XkVpeqIpxboMOA4H0wt8coC9XG4Swlwa uhE7ICIsmda71PGdd6bt =1o6b -----END PGP SIGNATURE----- --b8GWCKCLzrXbuNet--