From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ygagh-00026j-8x for qemu-devel@nongnu.org; Fri, 10 Apr 2015 11:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ygagc-0001zr-U0 for qemu-devel@nongnu.org; Fri, 10 Apr 2015 11:17:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ygagc-0001zZ-NQ for qemu-devel@nongnu.org; Fri, 10 Apr 2015 11:17:38 -0400 Date: Fri, 10 Apr 2015 17:17:30 +0200 From: Igor Mammedov Message-ID: <20150410171730.5701c87d@igors-macbook-pro.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua Cc: mst@redhat.com, qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, guz.fnst@cn.fujitsu.com, pbonzini@redhat.com On Thu, 2 Apr 2015 17:50:16 +0800 Zhu Guihua wrote: > This patchset adds support to hot unplug memory. > > Memory hot unplug is complicated multi-stage process. Unplug request > callback sends remove request. After guest os processes ejection > request, OSPM will execute _EJ0 to signal qemu that a device eject > will be to occur. Then qemu will call unplug callback to eject the > device. > > v6: > -improve documentation of memory hot unplug > -add trace event for device deletion > -put fix about "Memory device control fields" register in a separate > patch > > v5: > -reorganize the patchset > -add documentation to understand patch easily > -add MEMORY_SLOT_EJECT for initiating device eject > -add support to send qmp event to notify mgmt about memory unplug > error > > v4: > -reorganize the patchset > -drop the new API acpi_send_gpe_event() > -update ssdt-mem > > v3: > -commit message changes > -reorganize the patchset, squash and separate some patches > -update specs about acpi_mem_hotplug > -first cleanup external state, then un-map and un-register memory > device > > v2: > -do a generic for acpi to send gpe event > -unparent object by PC_MACHINE > -update description in acpi_mem_hotplug.txt > -combine the last two patches in the last version > -cleanup external state in acpi_memory_unplug_cb > > Tang Chen (3): > acpi, mem-hotplug: add acpi_memory_slot_status() to get MemStatus > acpi, mem-hotplug: add unplug request cb for memory device > acpi, mem-hotplug: add unplug cb for memory device > > Zhu Guihua (5): > docs: update documentation for memory hot unplug > acpi: extend aml_field() to support UpdateRule > acpi: fix "Memory device control fields" register > acpi: add hardware implementation for memory hot unplug > qmp-event: add event notification for memory hot unplug error > > docs/memory-hotplug.txt | 23 ++++++++-- > docs/qmp/qmp-events.txt | 17 +++++++ > docs/specs/acpi_mem_hotplug.txt | 58 +++++++++++++++++++++-- > hw/acpi/aml-build.c | 4 +- > hw/acpi/ich9.c | 19 ++++++-- > hw/acpi/memory_hotplug.c | 96 > ++++++++++++++++++++++++++++++++++++--- > hw/acpi/piix4.c | 17 +++++-- > hw/core/qdev.c | 2 +- > hw/i386/acpi-build.c | 25 ++++++++-- > hw/i386/acpi-dsdt-mem-hotplug.dsl | 13 +++++- > hw/i386/pc.c | 62 +++++++++++++++++++++++-- > include/hw/acpi/aml-build.h | 10 +++- > include/hw/acpi/memory_hotplug.h | 12 +++++ > include/hw/acpi/pc-hotplug.h | 3 ++ > include/hw/qdev-core.h | 1 + > monitor.c | 1 + > qapi/event.json | 14 ++++++ > trace-events | 4 ++ 18 files changed, 346 > insertions(+), 35 deletions(-) > Tested with RHEL7x64 guest, works as expected so far, hence Reviewed-by: Igor Mammedov PS: Note to maintainer: it needs update of dsdt and test tables blobs.