From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ira.weiny" Subject: Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW Date: Fri, 10 Apr 2015 14:11:44 -0400 Message-ID: <20150410181143.GA5716@phlsvsds.ph.intel.com> References: <5523CCD5.6030401@profitbricks.com> <5523D098.3020007@profitbricks.com> <1428517786.2980.180.camel@redhat.com> <20150408201015.GB28666@obsidianresearch.com> <20150410061610.GA26288@phlsvsds.ph.intel.com> <20150410161551.GA26419@obsidianresearch.com> <20150410173836.GE10675@phlsvsds.ph.intel.com> <1428688172.2980.372.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1428688172.2980.372.camel@redhat.com> Sender: netdev-owner@vger.kernel.org To: Doug Ledford Cc: Jason Gunthorpe , Michael Wang , Roland Dreier , Sean Hefty , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Hal Rosenstock , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Upinder Malhi , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , PJ Waskiewicz , Tatyana Nikolova , Or Gerlitz List-Id: linux-rdma@vger.kernel.org On Fri, Apr 10, 2015 at 01:49:32PM -0400, Doug Ledford wrote: > On Fri, 2015-04-10 at 13:38 -0400, ira.weiny wrote: > > > > > I think if we look closely we'll find that IPoIB today has a hard > > > requirement on cap_sa being true, so lets use that? > > > > I don't think that is appropriate. You have been advocating that the checks > > be clear as to what support we need. While currently the IPoIB layer does (for > > IB and OPA) require an SA I think those checks are only appropriate when it is > > attempting an SA query. > > > > The choice to run IPoIB at all is a different matter. > > Appropriately named or not, Jason's choice of words "has a hard > requirement" is correct ;-) Agreed. I meant that using "cap_sa" is not appropriate. Not that IPoIB did not have a hard requirement... :-D I actually think that _both_ the check for IB link layer and the "cap_sa" is required. Perhaps not at start up... Ira From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755755AbbDJSMF (ORCPT ); Fri, 10 Apr 2015 14:12:05 -0400 Received: from mga14.intel.com ([192.55.52.115]:47432 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbDJSMA (ORCPT ); Fri, 10 Apr 2015 14:12:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,558,1422950400"; d="scan'208";a="554242299" Date: Fri, 10 Apr 2015 14:11:44 -0400 From: "ira.weiny" To: Doug Ledford Cc: Jason Gunthorpe , Michael Wang , Roland Dreier , Sean Hefty , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Hal Rosenstock , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Upinder Malhi , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , PJ Waskiewicz , Tatyana Nikolova , Or Gerlitz , Jack Morgenstein , Haggai Eran , Ilya Nelkenbaum , Yann Droneaud , Bart Van Assche , Shachar Raindel , Sagi Grimberg , Devesh Sharma , Matan Barak , Moni Shoua , Jiri Kosina , Selvin Xavier , Mitesh Ahuja , Li RongQing , Rasmus Villemoes , Alex Estrin , Eric Dumazet , Erez Shitrit , Tom Gundersen , Chuck Lever Subject: Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW Message-ID: <20150410181143.GA5716@phlsvsds.ph.intel.com> References: <5523CCD5.6030401@profitbricks.com> <5523D098.3020007@profitbricks.com> <1428517786.2980.180.camel@redhat.com> <20150408201015.GB28666@obsidianresearch.com> <20150410061610.GA26288@phlsvsds.ph.intel.com> <20150410161551.GA26419@obsidianresearch.com> <20150410173836.GE10675@phlsvsds.ph.intel.com> <1428688172.2980.372.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428688172.2980.372.camel@redhat.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 10, 2015 at 01:49:32PM -0400, Doug Ledford wrote: > On Fri, 2015-04-10 at 13:38 -0400, ira.weiny wrote: > > > > > I think if we look closely we'll find that IPoIB today has a hard > > > requirement on cap_sa being true, so lets use that? > > > > I don't think that is appropriate. You have been advocating that the checks > > be clear as to what support we need. While currently the IPoIB layer does (for > > IB and OPA) require an SA I think those checks are only appropriate when it is > > attempting an SA query. > > > > The choice to run IPoIB at all is a different matter. > > Appropriately named or not, Jason's choice of words "has a hard > requirement" is correct ;-) Agreed. I meant that using "cap_sa" is not appropriate. Not that IPoIB did not have a hard requirement... :-D I actually think that _both_ the check for IB link layer and the "cap_sa" is required. Perhaps not at start up... Ira From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ira.weiny" Subject: Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW Date: Fri, 10 Apr 2015 14:11:44 -0400 Message-ID: <20150410181143.GA5716@phlsvsds.ph.intel.com> References: <5523CCD5.6030401@profitbricks.com> <5523D098.3020007@profitbricks.com> <1428517786.2980.180.camel@redhat.com> <20150408201015.GB28666@obsidianresearch.com> <20150410061610.GA26288@phlsvsds.ph.intel.com> <20150410161551.GA26419@obsidianresearch.com> <20150410173836.GE10675@phlsvsds.ph.intel.com> <1428688172.2980.372.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jason Gunthorpe , Michael Wang , Roland Dreier , Sean Hefty , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Hal Rosenstock , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Upinder Malhi , Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , PJ Waskiewicz , Tatyana Nikolova , Or Gerlitz Return-path: Received: from mga14.intel.com ([192.55.52.115]:47432 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbDJSMA (ORCPT ); Fri, 10 Apr 2015 14:12:00 -0400 Content-Disposition: inline In-Reply-To: <1428688172.2980.372.camel@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Apr 10, 2015 at 01:49:32PM -0400, Doug Ledford wrote: > On Fri, 2015-04-10 at 13:38 -0400, ira.weiny wrote: > > > > > I think if we look closely we'll find that IPoIB today has a hard > > > requirement on cap_sa being true, so lets use that? > > > > I don't think that is appropriate. You have been advocating that the checks > > be clear as to what support we need. While currently the IPoIB layer does (for > > IB and OPA) require an SA I think those checks are only appropriate when it is > > attempting an SA query. > > > > The choice to run IPoIB at all is a different matter. > > Appropriately named or not, Jason's choice of words "has a hard > requirement" is correct ;-) Agreed. I meant that using "cap_sa" is not appropriate. Not that IPoIB did not have a hard requirement... :-D I actually think that _both_ the check for IB link layer and the "cap_sa" is required. Perhaps not at start up... Ira