All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Ben Collins <ben.c@servergy.com>
Cc: dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
	Milan Broz <gmazyland@gmail.com>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH v2] dm crypt: fix deadlock when algo returns -EBUSY
Date: Fri, 10 Apr 2015 15:52:23 -0400	[thread overview]
Message-ID: <20150410195223.GA17880@redhat.com> (raw)
In-Reply-To: <CCE29825-C051-4612-86DD-1CA7A5CF095F@servergy.com>

On Fri, Apr 10 2015 at  1:56pm -0400,
Ben Collins <ben.c@servergy.com> wrote:

> 
> > On Apr 10, 2015, at 11:11 AM, Mike Snitzer <snitzer@redhat.com> wrote:
> > 
> > On Tue, Apr 07 2015 at  1:10pm -0400,
> > Ben Collins <ben.c@servergy.com> wrote:
> > 
> >> 
> >>> On Apr 7, 2015, at 11:28 AM, Mike Snitzer <snitzer@redhat.com> wrote:
> >>> 
> >>> On Tue, Apr 07 2015 at 11:55P -0400,
> >>> Mike Snitzer <snitzer@redhat.com> wrote:
> >>> 
> >>>> It looks like you're _always_ using the completion regardless of whether
> >>>> crypt_convert() will be waiting (e.g. even if error is 0).
> >>>> 
> >>>> I can see this "working" but it seems less than ideal.  Would it be
> >>>> better to record the need to use the completion in ctx and then
> >>>> conditionally call complete()?
> >>> 
> >>> Actually, how about using !completion_done() before calling complete()?
> >>> If you think this would be OK, any chance you could re-test with this?
> >> 
> >> I'll be able to test it before Friday (out of town). Thanks
> > 
> > Hi Ben,
> > 
> > I'm still waiting for test feedback from you on v2.  Fairly certain
> > you'll have the same results but I'd like to be certain before pushing
> > this upstream.
> 
> As expected, this patch works as well as what I had originally done.
> Thanks for reviewing it.

OK, thanks.  I've staged the change in linux-next, with a slightly
revised header, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=223c1aa8360a386

      reply	other threads:[~2015-04-10 19:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 16:09 [PATCH] dm-crypt: Fix deadlock when algo returns -EBUSY Ben Collins
2015-04-07 15:55 ` Mike Snitzer
2015-04-07 16:28   ` [PATCH v2] dm crypt: fix " Mike Snitzer
2015-04-07 17:10     ` Ben Collins
2015-04-10 15:11       ` Mike Snitzer
2015-04-10 15:12         ` Ben Collins
2015-04-10 17:56         ` Ben Collins
2015-04-10 19:52           ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410195223.GA17880@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=ben.c@servergy.com \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.