From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843AbbDKH1W (ORCPT ); Sat, 11 Apr 2015 03:27:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55252 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbbDKH1V (ORCPT ); Sat, 11 Apr 2015 03:27:21 -0400 Date: Sat, 11 Apr 2015 09:27:16 +0200 From: Greg KH To: Sudip Mukherjee Cc: Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH WIP] parport: add device model Message-ID: <20150411072716.GD10063@kroah.com> References: <1428676238-17141-1-git-send-email-sudipm.mukherjee@gmail.com> <20150410144955.GJ16501@mwanda> <20150411052651.GC3496@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150411052651.GC3496@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > > I know that I have done a rubbish review. I'm going to have to review > > this properly later. > main thing i wanted to know is if my approach is correct. since nothing > on that so I hope I am on the correct track. Thanks. > I will send in the next version in a day or two. At quick glance, you are on the right track. Writing a new bus is hard, I know, the documentation is lacking and it's tricky in places and the api is horrid in others. I know this, just never had the time to make it easier, so if you have any questions about it, please let me know. thanks, greg k-h