From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754287AbbDKIL5 (ORCPT ); Sat, 11 Apr 2015 04:11:57 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33906 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbbDKILp (ORCPT ); Sat, 11 Apr 2015 04:11:45 -0400 Date: Sat, 11 Apr 2015 13:41:34 +0530 From: Sudip Mukherjee To: Greg KH Cc: Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH WIP] parport: add device model Message-ID: <20150411081134.GA6092@sudip-PC> References: <1428676238-17141-1-git-send-email-sudipm.mukherjee@gmail.com> <20150410144955.GJ16501@mwanda> <20150411052651.GC3496@sudip-PC> <20150411072716.GD10063@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150411072716.GD10063@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 11, 2015 at 09:27:16AM +0200, Greg KH wrote: > On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > > > I know that I have done a rubbish review. I'm going to have to review > > > this properly later. > > main thing i wanted to know is if my approach is correct. since nothing > > on that so I hope I am on the correct track. Thanks. > > I will send in the next version in a day or two. > > At quick glance, you are on the right track. Writing a new bus is hard, > I know, the documentation is lacking and it's tricky in places and the > api is horrid in others. I know this, just never had the time to make > it easier, so if you have any questions about it, please let me know. well, as of now one question. I am planning like this : sys _______________|_____________ | | | | | bus ________|______ | parport _______|_____ | | devices drivers- lp, ppdev, panel etc.. _____|________ | | parport0 parport1 I can understand that drivers need to be binded to one device, so suppose ppdev wants to use parport0, how that binding will be done? do i need mark the driver in the parport->ddev.driver ? I think that should have been automatically done if i have a probe function for the bus... somehow I am missing this step in the other drivers codes. regards sudip > > thanks, > > greg k-h