From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhceE-000643-Q4 for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:35:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhceB-0002SQ-LH for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:35:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhceB-0002SM-DY for qemu-devel@nongnu.org; Mon, 13 Apr 2015 07:35:23 -0400 Date: Mon, 13 Apr 2015 12:35:07 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150413113506.GB2275@work-vm> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-31-git-send-email-dgilbert@redhat.com> <20150323042012.GN25043@voom.fritz.box> <20150326110517.GA2370@work-vm> <551909CA.7080605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551909CA.7080605@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, yanghy@cn.fujitsu.com, David Gibson * Paolo Bonzini (pbonzini@redhat.com) wrote: > > > On 26/03/2015 12:05, Dr. David Alan Gilbert wrote: > >>> > > + qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); > >>> > > + *old_vm_running = runstate_is_running(); > >> > > >> > I think that needs some explanation. Why are you doing a wakeup on > >> > the source host? > > This matches the existing code in migration_thread for the end of precopy; > > Paolo's explanation of what it does is here: > > https://lists.gnu.org/archive/html/qemu-devel/2014-08/msg04880.html > > The more I look at it, the more I'm convinced it's working by chance or > not working at all. Do you mean in general or in the postcopy case? > Here we probably need to do only the notifier_list_notify + > qapi_event_send_wakeup. Do you mean a : wakeup_reason = QEMU_WAKEUP_REASON_OTHER; notifier_list_notify(&wakeup_notifiers, &wakeup_reason); wakeup_reason = QEMU_WAKEUP_REASON_NONE; qapi_event_send_wakeup(&error); which I guess would need wrapping up in vl.c (It's not really clear to me what this stuff does even with your previous explanation; if it's to do with migrating something suspended-to-ram I guess a postcopy is possible but it doesn't seem that sensible to use postcopy for a machine with a CPU that isn't running). Dave > > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK