Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj

From: Jiri Pirko <jiri@resnulli.us>
To: sfeldma@gmail.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	linux@roeck-us.net, f.fainelli@gmail.com,
	sridhar.samudrala@intel.com, ronen.arad@intel.com,
	andrew@lunn.ch
Subject: Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj
Date: Mon, 13 Apr 2015 15:16:25 +0200	[thread overview]
Message-ID: <20150413131625.GC2090@nanopsycho.lan> (raw)
In-Reply-To: <1428905838-14920-8-git-send-email-sfeldma@gmail.com>

Mon, Apr 13, 2015 at 08:17:01AM CEST, sfeldma@gmail.com wrote:
>From: Scott Feldman <sfeldma@gmail.com>
>
>VLAN obj has flags (PVID and untagged) as well as start and end vid ranges.
>The swdev driver can optimize programing the device using the ranges.
>
>Signed-off-by: Scott Feldman <sfeldma@gmail.com>
>---
> include/net/switchdev.h |    8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/include/net/switchdev.h b/include/net/switchdev.h
>index f5f7733..d3cc8eb 100644
>--- a/include/net/switchdev.h
>+++ b/include/net/switchdev.h
>@@ -45,12 +45,20 @@ struct fib_info;
> 
> enum swdev_obj_id {
> 	SWDEV_OBJ_UNDEFINED,
>+	SWDEV_OBJ_PORT_VLAN,
> };
> 
> struct swdev_obj {
> 	enum swdev_obj_id id;
> 	enum swdev_trans trans;
> 	u32 flags;
>+	union {
>+		struct swdev_obj_vlan {			/* PORT_VLAN */
>+			u16 flags;
>+			u16 vid_start;
>+			u16 vid_end;
>+		} vlan;
>+	};

Same here. Please squash this with the next patch.

> };
> 
> /**
>-- 
>1.7.10.4
>