From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752028AbbDMW7A (ORCPT ); Mon, 13 Apr 2015 18:59:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36033 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbbDMW6z (ORCPT ); Mon, 13 Apr 2015 18:58:55 -0400 Date: Mon, 13 Apr 2015 17:58:49 -0500 From: Josh Poimboeuf To: Minfei Huang Cc: Petr Mladek , sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] livepatch: Add a new function to verify the address and name match for extra module Message-ID: <20150413225849.GC4412@treble.hsd1.ky.comcast.net> References: <1428844554-4015-1-git-send-email-minfei.huang@hotmail.com> <20150413083725.GA16088@pathway.suse.cz> <20150413094121.GD16088@pathway.suse.cz> <20150413102240.GE16088@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2015 at 06:37:10PM +0800, Minfei Huang wrote: > For my patches, I think it is used by the persion which will compose the > patch individually, not for the manufactor. > > Yes, Verifying extra function address is more useless in general, due to > the changable address on different system. > > IMO, we shall do our best to make livepatch more robust. IIUC, to use this, you'd have to load the module first, manually look up the module function's address, and _then_ build the patch for the running system. And the resulting patch wouldn't work on other systems. Do you have concrete plans to use it this way? Just trying to understand if this is needed for a real world usage scenario. -- Josh