From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbbDNGcP (ORCPT ); Tue, 14 Apr 2015 02:32:15 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:33530 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941AbbDNGcH convert rfc822-to-8bit (ORCPT ); Tue, 14 Apr 2015 02:32:07 -0400 Date: Tue, 14 Apr 2015 08:31:57 +0200 From: David Hildenbrand To: Christoffer Dall Cc: Alex =?UTF-8?B?QmVubsOpZQ==?= , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, peter.maydell@linaro.org, agraf@suse.de, drjones@redhat.com, pbonzini@redhat.com, zhichao.huang@linaro.org, jan.kiszka@siemens.com, r65777@freescale.com, bp@suse.de, Gleb Natapov , Jonathan Corbet , Russell King , "open list:DOCUMENTATION" , open list Subject: Re: [PATCH v2 04/10] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl Message-ID: <20150414083157.65733022@thinkpad-w530> In-Reply-To: <20150413121231.GO6186@cbox> References: <1427814488-28467-1-git-send-email-alex.bennee@linaro.org> <1427814488-28467-5-git-send-email-alex.bennee@linaro.org> <20150413121231.GO6186@cbox> Organization: IBM Deutschland GmbH X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15041406-0009-0000-0000-000003CD7A30 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, Mar 31, 2015 at 04:08:02PM +0100, Alex Bennée wrote: > > This commit adds a stub function to support the KVM_SET_GUEST_DEBUG > > ioctl. Currently any operation flag will return EINVAL. Actual > > functionality will be added with further patches. > > > > Signed-off-by: Alex Bennée . > > > > --- > > v2 > > - simplified form of the ioctl (stuff will go into setup_debug) > > > > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt > > index b112efc..06c5064 100644 > > --- a/Documentation/virtual/kvm/api.txt > > +++ b/Documentation/virtual/kvm/api.txt > > @@ -2604,7 +2604,7 @@ handled. > > 4.87 KVM_SET_GUEST_DEBUG > > > > Capability: KVM_CAP_SET_GUEST_DEBUG > > -Architectures: x86, s390, ppc > > +Architectures: x86, s390, ppc, arm64 > > Type: vcpu ioctl > > Parameters: struct kvm_guest_debug (in) > > Returns: 0 on success; -1 on error > > diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c > > index 5560f74..445933d 100644 > > --- a/arch/arm/kvm/arm.c > > +++ b/arch/arm/kvm/arm.c > > @@ -183,6 +183,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > > case KVM_CAP_ARM_PSCI: > > case KVM_CAP_ARM_PSCI_0_2: > > case KVM_CAP_READONLY_MEM: > > + case KVM_CAP_SET_GUEST_DEBUG: > > r = 1; > > break; > > shouldn't you wait with advertising this capability until you've > implemented support for it? > I think this would work for now, however it's not very practical - in the end one has to sense which debug flags are actually supported. Question is if he wants to add initial support and extend functionality and flags with each patch or enable the whole set of features in one shot at the end. Doing the latter seems more practicable to me (especially as the debug features are added in the same patch series). David From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v2 04/10] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl Date: Tue, 14 Apr 2015 08:31:57 +0200 Message-ID: <20150414083157.65733022@thinkpad-w530> References: <1427814488-28467-1-git-send-email-alex.bennee@linaro.org> <1427814488-28467-5-git-send-email-alex.bennee@linaro.org> <20150413121231.GO6186@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Russell King , kvm@vger.kernel.org, Jonathan Corbet , marc.zyngier@arm.com, jan.kiszka@siemens.com, "open list:DOCUMENTATION" , open list , Gleb Natapov , zhichao.huang@linaro.org, r65777@freescale.com, pbonzini@redhat.com, bp@suse.de, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Christoffer Dall Return-path: In-Reply-To: <20150413121231.GO6186@cbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org PiBPbiBUdWUsIE1hciAzMSwgMjAxNSBhdCAwNDowODowMlBNICswMTAwLCBBbGV4IEJlbm7DqWUg d3JvdGU6Cj4gPiBUaGlzIGNvbW1pdCBhZGRzIGEgc3R1YiBmdW5jdGlvbiB0byBzdXBwb3J0IHRo ZSBLVk1fU0VUX0dVRVNUX0RFQlVHCj4gPiBpb2N0bC4gQ3VycmVudGx5IGFueSBvcGVyYXRpb24g ZmxhZyB3aWxsIHJldHVybiBFSU5WQUwuIEFjdHVhbAo+ID4gZnVuY3Rpb25hbGl0eSB3aWxsIGJl IGFkZGVkIHdpdGggZnVydGhlciBwYXRjaGVzLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbGV4 IEJlbm7DqWUgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+Lgo+ID4gCj4gPiAtLS0KPiA+IHYyCj4g PiAgIC0gc2ltcGxpZmllZCBmb3JtIG9mIHRoZSBpb2N0bCAoc3R1ZmYgd2lsbCBnbyBpbnRvIHNl dHVwX2RlYnVnKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi92aXJ0dWFsL2t2 bS9hcGkudHh0IGIvRG9jdW1lbnRhdGlvbi92aXJ0dWFsL2t2bS9hcGkudHh0Cj4gPiBpbmRleCBi MTEyZWZjLi4wNmM1MDY0IDEwMDY0NAo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi92aXJ0dWFsL2t2 bS9hcGkudHh0Cj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL3ZpcnR1YWwva3ZtL2FwaS50eHQKPiA+ IEBAIC0yNjA0LDcgKzI2MDQsNyBAQCBoYW5kbGVkLgo+ID4gIDQuODcgS1ZNX1NFVF9HVUVTVF9E RUJVRwo+ID4gIAo+ID4gIENhcGFiaWxpdHk6IEtWTV9DQVBfU0VUX0dVRVNUX0RFQlVHCj4gPiAt QXJjaGl0ZWN0dXJlczogeDg2LCBzMzkwLCBwcGMKPiA+ICtBcmNoaXRlY3R1cmVzOiB4ODYsIHMz OTAsIHBwYywgYXJtNjQKPiA+ICBUeXBlOiB2Y3B1IGlvY3RsCj4gPiAgUGFyYW1ldGVyczogc3Ry dWN0IGt2bV9ndWVzdF9kZWJ1ZyAoaW4pCj4gPiAgUmV0dXJuczogMCBvbiBzdWNjZXNzOyAtMSBv biBlcnJvcgo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2t2bS9hcm0uYyBiL2FyY2gvYXJtL2t2 bS9hcm0uYwo+ID4gaW5kZXggNTU2MGY3NC4uNDQ1OTMzZCAxMDA2NDQKPiA+IC0tLSBhL2FyY2gv YXJtL2t2bS9hcm0uYwo+ID4gKysrIGIvYXJjaC9hcm0va3ZtL2FybS5jCj4gPiBAQCAtMTgzLDYg KzE4Myw3IEBAIGludCBrdm1fdm1faW9jdGxfY2hlY2tfZXh0ZW5zaW9uKHN0cnVjdCBrdm0gKmt2 bSwgbG9uZyBleHQpCj4gPiAgCWNhc2UgS1ZNX0NBUF9BUk1fUFNDSToKPiA+ICAJY2FzZSBLVk1f Q0FQX0FSTV9QU0NJXzBfMjoKPiA+ICAJY2FzZSBLVk1fQ0FQX1JFQURPTkxZX01FTToKPiA+ICsJ Y2FzZSBLVk1fQ0FQX1NFVF9HVUVTVF9ERUJVRzoKPiA+ICAJCXIgPSAxOwo+ID4gIAkJYnJlYWs7 Cj4gCj4gc2hvdWxkbid0IHlvdSB3YWl0IHdpdGggYWR2ZXJ0aXNpbmcgdGhpcyBjYXBhYmlsaXR5 IHVudGlsIHlvdSd2ZQo+IGltcGxlbWVudGVkIHN1cHBvcnQgZm9yIGl0Pwo+IAoKSSB0aGluayB0 aGlzIHdvdWxkIHdvcmsgZm9yIG5vdywgaG93ZXZlciBpdCdzIG5vdCB2ZXJ5IHByYWN0aWNhbAot IGluIHRoZSBlbmQgb25lIGhhcyB0byBzZW5zZSB3aGljaCBkZWJ1ZyBmbGFncyBhcmUgYWN0dWFs bHkgc3VwcG9ydGVkLgoKUXVlc3Rpb24gaXMgaWYgaGUgd2FudHMgdG8gYWRkIGluaXRpYWwgc3Vw cG9ydCBhbmQgZXh0ZW5kIGZ1bmN0aW9uYWxpdHkgYW5kCmZsYWdzIHdpdGggZWFjaCBwYXRjaCBv ciBlbmFibGUgdGhlIHdob2xlIHNldCBvZiBmZWF0dXJlcyBpbiBvbmUgc2hvdCBhdCB0aGUKZW5k LgoKRG9pbmcgdGhlIGxhdHRlciBzZWVtcyBtb3JlIHByYWN0aWNhYmxlIHRvIG1lIChlc3BlY2lh bGx5IGFzIHRoZSBkZWJ1ZyBmZWF0dXJlcwphcmUgYWRkZWQgaW4gdGhlIHNhbWUgcGF0Y2ggc2Vy aWVzKS4KCkRhdmlkCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0 cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: dahi@linux.vnet.ibm.com (David Hildenbrand) Date: Tue, 14 Apr 2015 08:31:57 +0200 Subject: [PATCH v2 04/10] KVM: arm: guest debug, add stub KVM_SET_GUEST_DEBUG ioctl In-Reply-To: <20150413121231.GO6186@cbox> References: <1427814488-28467-1-git-send-email-alex.bennee@linaro.org> <1427814488-28467-5-git-send-email-alex.bennee@linaro.org> <20150413121231.GO6186@cbox> Message-ID: <20150414083157.65733022@thinkpad-w530> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > On Tue, Mar 31, 2015 at 04:08:02PM +0100, Alex Benn?e wrote: > > This commit adds a stub function to support the KVM_SET_GUEST_DEBUG > > ioctl. Currently any operation flag will return EINVAL. Actual > > functionality will be added with further patches. > > > > Signed-off-by: Alex Benn?e . > > > > --- > > v2 > > - simplified form of the ioctl (stuff will go into setup_debug) > > > > diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt > > index b112efc..06c5064 100644 > > --- a/Documentation/virtual/kvm/api.txt > > +++ b/Documentation/virtual/kvm/api.txt > > @@ -2604,7 +2604,7 @@ handled. > > 4.87 KVM_SET_GUEST_DEBUG > > > > Capability: KVM_CAP_SET_GUEST_DEBUG > > -Architectures: x86, s390, ppc > > +Architectures: x86, s390, ppc, arm64 > > Type: vcpu ioctl > > Parameters: struct kvm_guest_debug (in) > > Returns: 0 on success; -1 on error > > diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c > > index 5560f74..445933d 100644 > > --- a/arch/arm/kvm/arm.c > > +++ b/arch/arm/kvm/arm.c > > @@ -183,6 +183,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > > case KVM_CAP_ARM_PSCI: > > case KVM_CAP_ARM_PSCI_0_2: > > case KVM_CAP_READONLY_MEM: > > + case KVM_CAP_SET_GUEST_DEBUG: > > r = 1; > > break; > > shouldn't you wait with advertising this capability until you've > implemented support for it? > I think this would work for now, however it's not very practical - in the end one has to sense which debug flags are actually supported. Question is if he wants to add initial support and extend functionality and flags with each patch or enable the whole set of features in one shot at the end. Doing the latter seems more practicable to me (especially as the debug features are added in the same patch series). David