All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Tom Yan <tom.ty89@gmail.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Remove illogical/bogus "Automatic" mode from "Broadcast RGB" property
Date: Tue, 14 Apr 2015 11:38:57 +0300	[thread overview]
Message-ID: <20150414083857.GI11009@intel.com> (raw)
In-Reply-To: <CAGnHSEna5Vn5ZAEVantsAOs2LAByAgJ2y=LxTpjp5jrkV2xJwg@mail.gmail.com>

On Tue, Apr 14, 2015 at 02:22:53PM +0800, Tom Yan wrote:
> It's not about whether it follows every line of the spec, but whether
> it makes sense to follow.
> 
> But I'm not going to argue about this anymore, I've written enough to
> show what's the logical error, yet seems I am the only one in the
> world who sees a problem in switching color range according to
> resolution and refresh rate, which I don't see any hardware vendor
> would/should follow either. So if you don't see a problem here, do
> whatever you like.

You assume no one follows the spec, but all I have to do is look at
the TV next to me and see that you're wrong.

It's extremely unfortunate that displays can apparently get the
appropriate logo without following the spec. I can only conclude
that whatever conformance testing is done is insufficient.

One option I was thinking would be to find some other hint in the
EDID that could tell us whether the device is likely to be spec
compliant, but sadly I've not found anything that would appear
to work.

> 
> 
> On 13 April 2015 at 22:22, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Mon, Apr 13, 2015 at 03:13:12PM +0100, Damien Lespiau wrote:
> >> On Wed, Apr 08, 2015 at 07:18:06PM +0800, Tom Yan wrote:
> >> > https://bugzilla.kernel.org/show_bug.cgi?id=94921
> >> >
> >> > As mentioned in the above bug report, switching output color range
> >> > "Automatically" according to current mode does not make sense in
> >> > computer use case.
> >>
> >> Current code seems correct to me after re-reading CEA-861-E again. However can
> >> we do better? Maybe! From the spec:
> >>
> >> "The QS (AVI Q support) bit of byte 3 allows a display to declare that it
> >> supports the reception of either type of quantization range for any video
> >> format, under the direction of InfoFrame Q data (see Section 6.4 for
> >> information concerning bits Q1 and Q0). This allows a source to override the
> >> default quantization range for any video format.  If the sink declares a
> >> selectable RGB Quantization Range (QS=1) then it shall expect limited range
> >> pixel values if it receives Q=1 and it shall expect full range pixel values if
> >> it receives Q=2 (see section 6.4). For other values of Q, the sink shall expect
> >> pixel values with the default range for the transmitted video format."
> >>
> >> So, for sinks that support it, we could default to sending the full
> >> range picture and overriding the quantization bit in the AVI infoframe.
> >>
> >> You could you try to run edid-decode [1] on your sink EDID to check if
> >> it supports overriding the quantization level (I added decoding the VCDB
> >> a while back).
> >>
> >> Ville, what do you think?
> >
> > Sure, if you can actually find a display that supports the Q bit.
> > I've not seen one yet :( They should have just made it mandatory,
> > otherwise I fear it's never going to catch on.
> >
> > --
> > Ville Syrjälä
> > Intel OTC

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-04-14  8:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 11:18 [PATCH] Remove illogical/bogus "Automatic" mode from "Broadcast RGB" property Tom Yan
2015-04-13 14:13 ` Damien Lespiau
2015-04-13 14:22   ` Ville Syrjälä
2015-04-14  6:22     ` Tom Yan
2015-04-14  8:38       ` Ville Syrjälä [this message]
2015-04-14 11:18         ` Tom Yan
2015-04-14 11:35           ` Tom Yan
2015-04-14 13:55             ` Tom Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150414083857.GI11009@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=tom.ty89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.