From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755297AbbDNKqj (ORCPT ); Tue, 14 Apr 2015 06:46:39 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:32990 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755144AbbDNKoj (ORCPT ); Tue, 14 Apr 2015 06:44:39 -0400 Date: Tue, 14 Apr 2015 12:44:46 +0200 From: Christoffer Dall To: Eric Auger Cc: eric.auger@st.com, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@linaro.org Subject: Re: [PATCH] KVM: arm: irqfd: fix value returned by kvm_irq_map_gsi Message-ID: <20150414104446.GA6186@cbox> References: <1428930119-21692-1-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428930119-21692-1-git-send-email-eric.auger@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2015 at 03:01:59PM +0200, Eric Auger wrote: > irqfd/arm curently does not support routing. kvm_irq_map_gsi is > supposed to return all the routing entries associated with the > provided gsi and return the number of those entries. We should > return 0 at this point. > > Signed-off-by: Eric Auger > --- > virt/kvm/arm/vgic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c > index 9ad074e..9b4f7d4 100644 > --- a/virt/kvm/arm/vgic.c > +++ b/virt/kvm/arm/vgic.c > @@ -1947,7 +1947,7 @@ int kvm_irq_map_gsi(struct kvm *kvm, > struct kvm_kernel_irq_routing_entry *entries, > int gsi) > { > - return gsi; > + return 0; > } > > int kvm_irq_map_chip_pin(struct kvm *kvm, unsigned irqchip, unsigned pin) > -- Acked-by: Christoffer Dall From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoffer Dall Subject: Re: [PATCH] KVM: arm: irqfd: fix value returned by kvm_irq_map_gsi Date: Tue, 14 Apr 2015 12:44:46 +0200 Message-ID: <20150414104446.GA6186@cbox> References: <1428930119-21692-1-git-send-email-eric.auger@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: eric.auger@st.com, kvm@vger.kernel.org, patches@linaro.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Eric Auger Return-path: Content-Disposition: inline In-Reply-To: <1428930119-21692-1-git-send-email-eric.auger@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Mon, Apr 13, 2015 at 03:01:59PM +0200, Eric Auger wrote: > irqfd/arm curently does not support routing. kvm_irq_map_gsi is > supposed to return all the routing entries associated with the > provided gsi and return the number of those entries. We should > return 0 at this point. > > Signed-off-by: Eric Auger > --- > virt/kvm/arm/vgic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c > index 9ad074e..9b4f7d4 100644 > --- a/virt/kvm/arm/vgic.c > +++ b/virt/kvm/arm/vgic.c > @@ -1947,7 +1947,7 @@ int kvm_irq_map_gsi(struct kvm *kvm, > struct kvm_kernel_irq_routing_entry *entries, > int gsi) > { > - return gsi; > + return 0; > } > > int kvm_irq_map_chip_pin(struct kvm *kvm, unsigned irqchip, unsigned pin) > -- Acked-by: Christoffer Dall From mboxrd@z Thu Jan 1 00:00:00 1970 From: christoffer.dall@linaro.org (Christoffer Dall) Date: Tue, 14 Apr 2015 12:44:46 +0200 Subject: [PATCH] KVM: arm: irqfd: fix value returned by kvm_irq_map_gsi In-Reply-To: <1428930119-21692-1-git-send-email-eric.auger@linaro.org> References: <1428930119-21692-1-git-send-email-eric.auger@linaro.org> Message-ID: <20150414104446.GA6186@cbox> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 13, 2015 at 03:01:59PM +0200, Eric Auger wrote: > irqfd/arm curently does not support routing. kvm_irq_map_gsi is > supposed to return all the routing entries associated with the > provided gsi and return the number of those entries. We should > return 0 at this point. > > Signed-off-by: Eric Auger > --- > virt/kvm/arm/vgic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c > index 9ad074e..9b4f7d4 100644 > --- a/virt/kvm/arm/vgic.c > +++ b/virt/kvm/arm/vgic.c > @@ -1947,7 +1947,7 @@ int kvm_irq_map_gsi(struct kvm *kvm, > struct kvm_kernel_irq_routing_entry *entries, > int gsi) > { > - return gsi; > + return 0; > } > > int kvm_irq_map_chip_pin(struct kvm *kvm, unsigned irqchip, unsigned pin) > -- Acked-by: Christoffer Dall