From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YhxdD-0006RA-Mx
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 05:59:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhxd8-0006e0-T9
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 05:59:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Yhxd8-0006dn-KK
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 05:59:42 -0400
Date: Tue, 14 Apr 2015 11:59:21 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150414115900-mutt-send-email-mst@redhat.com>
References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com>
	<1428055432-12120-20-git-send-email-zhaoshenglong@huawei.com>
	<87mw2cj9zi.fsf@linaro.org> <552C691D.3090702@huawei.com>
	<CAFEAcA9wjjCCBVzAJuB945qKQXsShKn-Lu4R8ExYKg1Ga3-j2w@mail.gmail.com>
	<552CE41B.2070501@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <552CE41B.2070501@huawei.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe
 controller in ACPI DSDT table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, hangaohuai@huawei.com, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, Mark Salter <msalter@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Laszlo Ersek <lersek@redhat.com>, Hanjun Guo <hanjun.guo@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On Tue, Apr 14, 2015 at 05:55:39PM +0800, Shannon Zhao wrote:
> On 2015/4/14 17:30, Peter Maydell wrote:
> > On 14 April 2015 at 02:10, Shannon Zhao <zhaoshenglong@huawei.com> wr=
ote:
> >> On 2015/4/13 23:58, Alex Benn=E9e wrote:
> >>>
> >>> Shannon Zhao <zhaoshenglong@huawei.com> writes:
> >>>> +    UUID =3D aml_touuid(0x33DB4D5B, 0x1FF7, 0x401C, 0x9657,
> >>>> 0x7441C03DD766);
> >>>
> >>> This looks like a fairly unreadable uuid already. What are these ma=
gic numbers?
> >>>
> >>
> >> Yes, this will be modified to use string according to the spec. Like=
 below way:
> >>
> >> UUID =3D aml_touuid("33DB4D5B-1FF7-401C-9657-7441C03DD766");
> >=20
> > Those are still magic numbers, you've  just put them into
> > a different format. Where do they come from? What do they mean?
> >=20
>=20
> This is from the PCI Firmware Spec.
>=20
> "The _OSC interface for a PCI/PCI-X/PCI Express hierarchy is identified=
 by the Universal Unique
> IDentifier (UUID) 33db4d5b-1ff7-401c-9657-7441c03dd766."
>=20
> "The UUID in _DSM in this context is {E5C937D0-3553-4d7a-9117-EA4D19C34=
34D}"
>=20
> Maybe I should use a macro definition for them.

If there's a single instance of use, a comment would
do as well.

> --=20
> Thanks,
> Shannon