All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_balloon: drop virtio_balloon_stat_modern
Date: Tue, 14 Apr 2015 12:13:27 +0200	[thread overview]
Message-ID: <20150414121327.4caacfba.cornelia.huck__7240.38702105663$1429006434$gmane$org@de.ibm.com> (raw)
In-Reply-To: <1429005625-23181-1-git-send-email-mst@redhat.com>

On Tue, 14 Apr 2015 12:01:13 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Looks like we are better off sticking with the misaligned stat struct,
> to reduce the amount of virtio 1 specific code in balloon.  So let's do
> it.
> 
> Add a detailed comment to reduce the chance people copy this bad example.
> 
> This also fixes a bug on BE architectures: tag should use
> cpu_to_le16, not cpu_to_le32.
> 
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Just reposting so it's easier to apply.
> Feel free to squash into previous patch if you think it's
> neater.

+1 for squashing from me. My A-b would also apply to the squashed patch.
> 
>  include/uapi/linux/virtio_balloon.h | 33 +++++++++++++++++++++++++--------
>  drivers/virtio/virtio_balloon.c     | 19 ++++---------------
>  2 files changed, 29 insertions(+), 23 deletions(-)

  reply	other threads:[~2015-04-14 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 10:01 [PATCH] virtio_balloon: drop virtio_balloon_stat_modern Michael S. Tsirkin
2015-04-14 10:01 ` Michael S. Tsirkin
2015-04-14 10:13 ` Cornelia Huck [this message]
2015-04-14 10:13 ` Cornelia Huck
2015-04-14 10:13   ` Cornelia Huck
2015-04-15  3:15   ` Rusty Russell
2015-04-15  3:15     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20150414121327.4caacfba.cornelia.huck__7240.38702105663$1429006434$gmane$org@de.ibm.com' \
    --to=cornelia.huck@de.ibm.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.