From: Al Viro <viro@ZenIV.linux.org.uk>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: I_CLEAR bug while shrinking dcache
Date: Tue, 14 Apr 2015 13:44:29 +0100 [thread overview]
Message-ID: <20150414124428.GW889@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20150414081254.GD14691@type.youpi.perso.aquilenet.fr>
On Tue, Apr 14, 2015 at 10:12:54AM +0200, Samuel Thibault wrote:
> So it seems that shrink_dentry_list was trying to kill an inode which
> already has I_CLEAR. I'll be trying the attached patch in the next
> days.
That patch is just papering over the problem. What you have is a dentry
with ->d_inode pointing to something with I_CLEAR set.
So either
* dentry has already been through __dentry_kill()
* or you have live dentry with ->d_inode somehow not contributing
to refcount of ->d_inode
* or you have an inode with positive refcount and I_CLEAR set.
The first variant can happen, but in that case it should have had
DCACHE_DENTRY_KILLED set by said __dentry_kill() and skipped. The other
two are clear inode refcounting bugs.
Do you have a reproducer for that?
next prev parent reply other threads:[~2015-04-14 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 8:12 I_CLEAR bug while shrinking dcache Samuel Thibault
2015-04-14 12:44 ` Al Viro [this message]
2015-04-14 14:44 ` Samuel Thibault
2015-04-14 14:44 ` Samuel Thibault
2015-04-20 22:58 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414124428.GW889@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.