From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 14 Apr 2015 17:31:05 +0200 Subject: [U-Boot] [PATCH v2 10/13] arm: mvebu: Add dynamic SoC detection to mbus driver In-Reply-To: <1429008415-27458-11-git-send-email-sr@denx.de> References: <1429008415-27458-1-git-send-email-sr@denx.de> <1429008415-27458-11-git-send-email-sr@denx.de> Message-ID: <20150414173105.40f74c27@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, On Tue, 14 Apr 2015 12:46:52 +0200, Stefan Roese wrote: > + if (mvebu_soc_family() == MVEBU_SOC_AXP) > + w->mbus_attr |= ATTR_HW_COHERENCY; Why is this Armada XP specific? Both Armada XP and Armada 38x support HW I/O coherency. But are you actually using HW I/O coherency in U-Boot for Armada XP ? It would probably be simpler to not use HW I/O coherency at all in U-Boot, be it for AXP or A38x. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com