From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Cohen Subject: Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures Date: Tue, 14 Apr 2015 22:23:16 +0300 Message-ID: <20150414192316.GB27750@mtldesk30> References: <1428916918-24404-1-git-send-email-honli@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1428916918-24404-1-git-send-email-honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Honggang Li Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote: > @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr) > static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id) > { > struct page *page; > - u64 addr; > + u64 addr = 0; > int err; > int nid = dev_to_node(&dev->pdev->dev); > I really don't see any reason why you need to set addr to 0. Can you please explain this? Other than that the patch is ok. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbbDNTXa (ORCPT ); Tue, 14 Apr 2015 15:23:30 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:35054 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753409AbbDNTXW (ORCPT ); Tue, 14 Apr 2015 15:23:22 -0400 From: Eli Cohen X-Google-Original-From: Eli Cohen Date: Tue, 14 Apr 2015 22:23:16 +0300 To: Honggang Li Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures Message-ID: <20150414192316.GB27750@mtldesk30> References: <1428916918-24404-1-git-send-email-honli@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428916918-24404-1-git-send-email-honli@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote: > @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr) > static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id) > { > struct page *page; > - u64 addr; > + u64 addr = 0; > int err; > int nid = dev_to_node(&dev->pdev->dev); > I really don't see any reason why you need to set addr to 0. Can you please explain this? Other than that the patch is ok.