From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756478AbbDOVWi (ORCPT ); Wed, 15 Apr 2015 17:22:38 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:52829 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753654AbbDOVW3 (ORCPT ); Wed, 15 Apr 2015 17:22:29 -0400 Date: Wed, 15 Apr 2015 17:22:27 -0400 (EDT) Message-Id: <20150415.172227.1813336970100255734.davem@davemloft.net> To: tglx@linutronix.de Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, dingtianhong@huawei.com, zhangfei.gao@linaro.org, dan.carpenter@oracle.com, netdev@vger.kernel.org Subject: Re: [patch v2] net: hip04: Make tx coalesce timer actually work From: David Miller In-Reply-To: References: <20150414.141529.797692010779414843.davem@davemloft.net> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Apr 2015 14:22:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner Date: Tue, 14 Apr 2015 21:42:42 +0200 (CEST) > The code sets the expiry value of the timer to a relative value and > starts it with hrtimer_start_expires. That's fine, but that only works > once. The timer is started in relative mode, so the expiry value gets > overwritten with the absolut expiry time (now + expiry). > > So once the timer expired, a new call to hrtimer_start_expires results > in an immidiately expired timer, because the expiry value is > already in the past. > > Use the proper mechanisms to (re)start the timer in the intended way. > > Signed-off-by: Thomas Gleixner Applied, thanks Thomas.