All of lore.kernel.org
 help / color / mirror / Atom feed
From: Honggang LI <honli@redhat.com>
To: Eli Cohen <eli@dev.mellanox.co.il>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures
Date: Wed, 15 Apr 2015 11:12:03 +0800	[thread overview]
Message-ID: <20150415031203.GA4881@honli.nay.redhat.com> (raw)
In-Reply-To: <20150414192316.GB27750@mtldesk30>

On Tue, Apr 14, 2015 at 10:23:16PM +0300, Eli Cohen wrote:
> On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote:
> > @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr)
> >  static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id)
> >  {
> >  	struct page *page;
> > -	u64 addr;
> > +	u64 addr = 0;
> >  	int err;
> >  	int nid = dev_to_node(&dev->pdev->dev);
> >  
> 
> I really don't see any reason why you need to set addr to 0. Can you
> please explain this?
> Other than that the patch is ok.

Sorry, I trid my best to explain it. But failed. I'm fine to remove it.
New patch will be submit. And I will insert a fix tag in it.

Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to
firmware)

thanks

      reply	other threads:[~2015-04-15  3:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13  9:21 [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures Honggang Li
2015-04-13  9:21 ` Honggang Li
2015-04-14 18:05 ` David Miller
     [not found] ` <1428916918-24404-1-git-send-email-honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-14 19:23   ` Eli Cohen
2015-04-14 19:23     ` Eli Cohen
2015-04-15  3:12     ` Honggang LI [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150415031203.GA4881@honli.nay.redhat.com \
    --to=honli@redhat.com \
    --cc=eli@dev.mellanox.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.