From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: UIO pci-generic support broke igb_uio Date: Wed, 15 Apr 2015 08:57:31 -0700 Message-ID: <20150415085731.054f701f@urahara> References: <20150414180620.03deb8ee@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Zhou, Danny" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Wed, 15 Apr 2015 07:19:39 +0000 "Zhou, Danny" wrote: > Could you please send out the steps for us to reproduce it? I guess you have applied > v6 interrupt patches to perform interrupt related tests, right? > > We cannot reproduce it now. > > The support to in_kernel uio_pci_generic avoids using igb_uio this DPDK specific kernel module, > so it will be much easier for any Linux distribution to package DPDK. Very simple. Run with link state enabled and igb_uio driver. Looking more closely, I think the right way to fix this is to fix the upstream uio_pci_generic to support controlling interrupts properly, rather than trying to do it directly in userspace. The problem is that doing it userspace is inherently racy because the userspace config access does not do proper locking. It really is an upstream kernel bug. Will send patch upstream to do it the right way. But that won't help distributions.