From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756582AbbDOSJl (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Apr 2015 14:09:41 -0400
Received: from mail.kernel.org ([198.145.29.136]:42509 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756184AbbDOSJd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Apr 2015 14:09:33 -0400
Date: Wed, 15 Apr 2015 15:09:27 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Namhyung Kim <namhyung@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: perf/tracepoints access to interpreted strings
Message-ID: <20150415180927.GR16027@kernel.org>
References: <552E8FB8.6010005@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <552E8FB8.6010005@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Apr 15, 2015 at 10:20:08AM -0600, David Ahern escreveu:
> I was hoping you could provide points on how to get access to an interpreted
> field in a tracepoint within perf.
 
> This is an example of the tracepoint:
 
> # cat /sys/kernel/debug/tracing/events/irq/softirq_exit/format
> name: softirq_exit
> ID: 99
> format:
> 	field:unsigned short common_type;	offset:0;	size:2;	signed:0;
> 	field:unsigned char common_flags;	offset:2;	size:1;	signed:0;
> 	field:unsigned char common_preempt_count;	offset:3;	size:1;	signed:0;
> 	field:int common_pid;	offset:4;	size:4;	signed:1;
> 	field:int common_padding;	offset:8;	size:4;	signed:1;
> 
> 	field:unsigned int vec;	offset:12;	size:4;	signed:0;
> 
> print fmt: "vec=%u [action=%s]", REC->vec, __print_symbolic(REC->vec, {
> HI_SOFTIRQ, "HI" }, { TIMER_SOFTIRQ, "TIMER" }, { NET_TX_SOFTIRQ, "NET_TX"
> }, { NET_RX_SOFTIRQ, "NET_RX" }, { BLOCK_SOFTIRQ, "BLOCK" }, {
> BLOCK_IOPOLL_SOFTIRQ, "BLOCK_IOPOLL" }, { TASKLET_SOFTIRQ, "TASKLET" }, {
> SCHED_SOFTIRQ, "SCHED" }, { HRTIMER_SOFTIRQ, "HRTIMER" }, { RCU_SOFTIRQ,
> "RCU" })
 
> I would like to programmatically extract the action string. 'perf script'
> prints the samples fine which suggests libtraceevent extracts the
> information somehow.
 
> Can you provide a suggestion -- something along the lines of
> perf_evsel__intval() or perf_evsel__rawptr()?

We'll gonna have to parse the "print fmt" thing and look for entries
surrounded by [], then match it with the list of parameters, so that we
can end up with a:

	const char *perf_evsel__enum_entry(struct perf_evsel *evsel,
					   struct perf_sample *sample,
					   const char *enum_name,
					   int value);

That would return one of "TIMER", "NET_TX", etc, that is, 0,
1, N.

If it is strictly an enum, i.e. no holes and just by looking at the
"format" file above I don't see how it could have holes, albeit enums
may have, we can as well have this:

	const char *perf_evsel__enum(struct perf_evsel *evsel,
				     struct perf_sample *sample,
				     const char *enum_name);

That would return an array of strings that you could directly access,
indexing using some of the fields.

I.e. internally we would see the tracepoint format file as:

 	field:enum action vec;	offset:12;	size:4;	signed:0;

	enum: action: TIMER, NET_TX, NET_RX, BLOCK, BLOCK_IOPOLL, TASKLET, SCHED, HRTIMER, RCU

- Arnaldo