From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757084AbbDPJvL (ORCPT ); Thu, 16 Apr 2015 05:51:11 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:36727 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754365AbbDPJvG (ORCPT ); Thu, 16 Apr 2015 05:51:06 -0400 Date: Thu, 16 Apr 2015 15:20:57 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] parport: modify parport subsystem to use devicemodel Message-ID: <20150416095007.GA5247@sudip-PC> References: <1429084124-2271-1-git-send-email-sudipm.mukherjee@gmail.com> <1429084124-2271-2-git-send-email-sudipm.mukherjee@gmail.com> <20150415133115.GG21491@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150415133115.GG21491@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2015 at 03:31:15PM +0200, Greg Kroah-Hartman wrote: > > + > > +} > > empty free functions are a huge red flag. So much so the kobject > documentation in the kernel says I get to make fun of anyone who tries > to do this. So please don't do this :) > i was just working on the v2 and I saw : "@release: pointer to the function that will clean up the object when the last reference to the object is released. This pointer is required, and it is not acceptable to pass kfree in as this function. If the caller does pass kfree to this function, you will be publicly mocked mercilessly by the kref maintainer". so i thought of checking and it looks like there are a few instances where kref has been passed as release. :) regards sudip >