From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933558AbbDPKKG (ORCPT ); Thu, 16 Apr 2015 06:10:06 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:33618 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753630AbbDPKJ7 (ORCPT ); Thu, 16 Apr 2015 06:09:59 -0400 Date: Thu, 16 Apr 2015 12:09:54 +0200 From: Ingo Molnar To: Pavel Machek Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, jgross@suse.com, roland@purestorage.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [patch for 4.0] x86: silence warning in /dev/mem support Message-ID: <20150416100954.GA7847@gmail.com> References: <20150416080440.GA507@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150416080440.GA507@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Machek wrote: > The compiler is right, the code is tricky, but it is also correct > AFAICT. > > Signed-off-by: Pavel Machek > > diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c > index fdf617c..8a8dce8 100644 > --- a/arch/x86/mm/ioremap.c > +++ b/arch/x86/mm/ioremap.c > @@ -341,7 +341,7 @@ void *xlate_dev_mem_ptr(phys_addr_t phys) > > addr = (void __force *)ioremap_cache(start, PAGE_SIZE); > if (addr) > - addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK)); > + addr = (void *)((unsigned long)addr | (unsigned long) (phys & ~PAGE_MASK)); What warning did it generate and which compiler version? Thanks, Ingo