From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933548AbbDPKP7 (ORCPT ); Thu, 16 Apr 2015 06:15:59 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35240 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756882AbbDPKPv (ORCPT ); Thu, 16 Apr 2015 06:15:51 -0400 Date: Thu, 16 Apr 2015 12:15:49 +0200 From: Pavel Machek To: Ingo Molnar Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, jgross@suse.com, roland@purestorage.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [patch for 4.0] x86: silence warning in /dev/mem support Message-ID: <20150416101549.GB27776@amd> References: <20150416080440.GA507@amd> <20150416100954.GA7847@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150416100954.GA7847@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2015-04-16 12:09:54, Ingo Molnar wrote: > > * Pavel Machek wrote: > > > The compiler is right, the code is tricky, but it is also correct > > AFAICT. > > > > Signed-off-by: Pavel Machek > > > > diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c > > index fdf617c..8a8dce8 100644 > > --- a/arch/x86/mm/ioremap.c > > +++ b/arch/x86/mm/ioremap.c > > @@ -341,7 +341,7 @@ void *xlate_dev_mem_ptr(phys_addr_t phys) > > > > addr = (void __force *)ioremap_cache(start, PAGE_SIZE); > > if (addr) > > - addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK)); > > + addr = (void *)((unsigned long)addr | (unsigned long) (phys & ~PAGE_MASK)); > > What warning did it generate and which compiler version? CC arch/x86/mm/ioremap.o arch/x86/mm/ioremap.c: In function ‘xlate_dev_mem_ptr’: arch/x86/mm/ioremap.c:363:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK)); ^ LD arch/x86/mm/built-in.o pavel@amd:/data/l/linux$ gcc --version gcc (Debian 4.9.2-10) 4.9.2 (Patch should apply to today's 4.1-rc0, too). Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html